Skip to content

NGF: control plane/data plane split docs #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 27, 2025

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented May 22, 2025

Now that the control plane/data plane split feature is in main in NGF, we can merge this docs feature branch into the upcoming NGF release branch for 2.0.

All PRs as a part of this branch were previously reviewed, but a once-over isn't a bad idea.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

bjee19 and others added 22 commits April 28, 2025 10:24
Problem: Added support for running NGINX in debug mode in NGF's CP-DP split which changes the old way to run NGINX in debug mode.

Solution: Update docs to show new way to run NGINX in debug mode.
Problem: With the new NGF architecture incoming, the process for setting up NGINX Plus is slightly different than before.

Solution: Update the docs to remove unnecessary steps and add extra context around creating NGINX Plus Secrets.
Add new CLI field and update CLI name for the changes in the split feature.
Update documentation on prometheus metrics.

Problem: Because NGF now uses NGINX Agent to export NGINX metrics, we need to update our documentation on metrics available and the example grafana dashboard.

Solution: Update the metrics.


* Add feedback
Mention that users can update the original Secrets to propagate changes to duplicate Secrets.
A few flags have been removed, and one new one has been added.
Update documentation on accessing nginx container

Problem: With our incoming changes to our control data plane split, the nginx container will no longer be in the NGF Pod. Thus all documentation on accessing the nginx container (logs, sending traffic, config...) need to be updated.

Solution: Updated the documentation. Mainly, when sending traffic in the examples, the host and IP of the NGINX Service are recorded after the Gateway is deployed. Also updated a link in the NGINX Plus feature document to point away from the NGINX Prometheus exporter and to the internal document showing metrics.
* NGF: Update architecture overview

* Apply suggestions from code review

Co-authored-by: Saylor Berman <[email protected]>

* Review feedback

* Improve diagrams

* Final feedback

---------

Co-authored-by: Saylor Berman <[email protected]>
The getting started guide needs to change with the new NGF architecture, specifically regarding the NodePorts. The user no longer needs to create the Service, and instead specifies configuration at installation time.
Update docs for CP/DP split telemetry changes.

Problem: Some small docs changes are needed for the new telemetry metrics/changes introduced with the control data plane split.

Solution: Add the new metrics. Also updated the data plane configuration document small error of including the namespace field in the gateway.infrastructure.parametersRef field since that does not exist.
With the control plane and data plane split in NGF, a secure connection is necessary for communication between the two entities. We secure this by default, but for production environments, users should use an official solution to secure this communication channel. This doc describes how to do that.
docs: Updata data plane configuration doc to reflect changes to NginxProxy resource
 docs: Introduces a new how-to guide on scaling control and data plane pods
Update tracing doc and Helm install doc
Agent updated some metrics names and descriptions. Updating the NGF doc that describes them.
Add "Deploy Data plane document" to guide users on how to create and modify the NGINX Data Plane.

Problem: Users want a guide on how to create and modify the NGINX Data Plane.

Solution: Added the guide.
docs: Updates Gateway Compatibility document to reflect new architecture changes.
Update missed imagePullSecret helm values
* docs: upgrade NGF from v1.x to v2.x
Problem: Agent metrics were updated, but the NGF sample dashboard was not.

Solution: Update the dashboard with the new metrics name.
@sjberman sjberman requested review from a team as code owners May 22, 2025 20:07
@github-actions github-actions bot added documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric labels May 22, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/590/

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content still all LGTM.

I might do my own editing pass on them as part of IA work.

Copy link

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sjberman sjberman merged commit 88df8b9 into ngf-release-2.0 May 27, 2025
6 checks passed
@sjberman sjberman deleted the ngf-feature-cp-dp-split branch May 27, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/ngf Issues related to NGINX Gateway Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants