Skip to content

feat: add disaster recovery guidance for NGINXaaS for Azure deployments #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 4, 2025

Conversation

kuthiala
Copy link
Contributor

@kuthiala kuthiala commented May 2, 2025

Proposed changes

Adds a section for disaster recovery guidance for NGINXaaS for Azure deployments.

Testing: Describe any testing that you did.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@kuthiala kuthiala requested a review from a team as a code owner May 2, 2025 21:51
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nginxaas NGINX as a Service for Azure labels May 2, 2025
Copy link

github-actions bot commented May 2, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/493/

@kuthiala kuthiala force-pushed the kuthiala-dev branch 3 times, most recently from 7942e5a to fc464e2 Compare May 2, 2025 22:08
@kuthiala kuthiala changed the title draft: add disaster recovery guidance for NGINXaaS for Azure deployments draft: feat: add disaster recovery guidance for NGINXaaS for Azure deployments May 2, 2025
@kuthiala kuthiala force-pushed the kuthiala-dev branch 2 times, most recently from 62c97e9 to 4e9df45 Compare May 2, 2025 22:51
@mjang
Copy link
Contributor

mjang commented May 2, 2025

2 min review:

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used NGINXaaS before, so you're welcome to ignore any/all of my comments. I am approving to expedite publishing if appropriate.

@kuthiala kuthiala requested a review from a team as a code owner May 4, 2025 04:45
@kuthiala kuthiala changed the title draft: feat: add disaster recovery guidance for NGINXaaS for Azure deployments feat: add disaster recovery guidance for NGINXaaS for Azure deployments May 4, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retaining approval so you can publish... but I do think you need to tell users "where" to write the code samples.

Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving now to make sure this is not blocked

@JTorreG JTorreG merged commit 6a91fde into main May 4, 2025
9 checks passed
@JTorreG JTorreG deleted the kuthiala-dev branch May 4, 2025 16:22
@JTorreG
Copy link
Contributor

JTorreG commented May 4, 2025

merging this PR as per conversation in Slack.

If there is any further feedback or fixes, we will address them in a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation product/nginxaas NGINX as a Service for Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants