-
Notifications
You must be signed in to change notification settings - Fork 132
N1C CSG unmanaged certificates #1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
|
@sylwang overall, this is excellent. I plan to comment on a few details. But first, a "big picture" question. I know that you can have unmanaged certs with an instance. I'm tempted to recommend moving unmanaged-certificates.md to the content/nginx-one-console/nginx-configs/certificates directory |
mjang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sylwang , you're an excellent writer. My suggested changes mostly relate to F5 styles.
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/config-sync-groups/manage-config-sync-groups.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Outdated
Show resolved
Hide resolved
content/nginx-one-console/nginx-configs/certificates/csg-unmanaged-certificates.md
Show resolved
Hide resolved
|
FYI, I'll be working Dec 22, 23, 29, 30, 31. I might be the only writer available during these days -- and I have no problem merging on my own, once we've addressed these suggestions. |
|
Note: probable release date now in January 2026 |
Co-authored-by: Mike Jang <[email protected]>
Proposed changes
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩