-
Notifications
You must be signed in to change notification settings - Fork 121
docs: consolidate glossary pages #1374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@ChisomUma FYI, I've submitted this internally for discussion / comment |
|
Sorry, accidentally hit the "Close" button. Reopened :) |
content/glossary/glossary.md
Outdated
| {{<bootstrap-table "table table-striped table-bordered">}} | ||
| | Term | Definition | | ||
| |-------------|-------------| | ||
| | **Config Sync Group** | A group of NGINX systems (or instances) with identical configurations. They may also share the same certificates. However, the instances in a Config Sync Group could belong to different systems and even different clusters. For more information, see this explanation of [Important considerations]({{< ref "/nginx-one/nginx-configs/config-sync-groups/manage-config-sync-groups.md#important-considerations" >}}) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NGINX Instance Manager currently calls this feature an Instance Group. We should document both terms as synonyms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | **Config Sync Group** | A group of NGINX systems (or instances) with identical configurations. They may also share the same certificates. However, the instances in a Config Sync Group could belong to different systems and even different clusters. For more information, see this explanation of [Important considerations]({{< ref "/nginx-one/nginx-configs/config-sync-groups/manage-config-sync-groups.md#important-considerations" >}}) | | |
| | **Config Sync Group** / **Instance Group** | A group of NGINX systems (or instances) with identical configurations. They may also share the same certificates. However, the instances in a Config Sync Group could belong to different systems and even different clusters. Also known as an Instance Group in NGINX Instance Manager. For more information, see this explanation of [Important considerations]({{< ref "/nginx-one/nginx-configs/config-sync-groups/manage-config-sync-groups.md#important-considerations" >}}) | |
content/glossary/glossary.md
Outdated
| | **Data Plane** | The data plane is the part of a network architecture that carries user traffic. It handles tasks like forwarding data packets between devices and managing network communication. In the context of NGINX, the data plane is responsible for tasks such as load balancing, caching, and serving web content. | | ||
| | **Instance** | An instance is an individual system with NGINX installed. You can group the instances of your choice in a Config Sync Group. When you add an instance to NGINX One, you need to use a data plane key. | | ||
| | **Namespace** | In F5 Distributed Cloud, a namespace groups a tenant’s configuration objects, similar to administrative domains. Every object in a namespace must have a unique name, and each namespace must be unique to its tenant. This setup ensures isolation, preventing cross-referencing of objects between namespaces. You'll see the namespace in the NGINX One Console URL as `/namespaces/<namespace name>/`. To switch an instance between namespaces, you have to deregister an instance from an old namespace, and register it on the new namespace. | | ||
| | **NGINX Agent** | A lightweight software component installed on NGINX instances to enable communication with the NGINX One console. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Agent also enables communication with NGINX Instance Manager.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | **NGINX Agent** | A lightweight software component installed on NGINX instances to enable communication with the NGINX One console. | | |
| | **NGINX Agent** | A lightweight software component installed on NGINX instances to enable communication with the NGINX One console. NGINX Agent also enables communication with NGINX Instance Manager. | |
content/glossary/glossary.md
Outdated
| | **Config Sync Group** | A group of NGINX systems (or instances) with identical configurations. They may also share the same certificates. However, the instances in a Config Sync Group could belong to different systems and even different clusters. For more information, see this explanation of [Important considerations]({{< ref "/nginx-one/nginx-configs/config-sync-groups/manage-config-sync-groups.md#important-considerations" >}}) | | ||
| | **Control Plane** | The control plane is the part of a network architecture that manages and controls the flow or data or traffic (the Data Plane). It is responsible for system-level tasks such as routing and traffic management. | | ||
| | **Data Plane** | The data plane is the part of a network architecture that carries user traffic. It handles tasks like forwarding data packets between devices and managing network communication. In the context of NGINX, the data plane is responsible for tasks such as load balancing, caching, and serving web content. | | ||
| | **Instance** | An instance is an individual system with NGINX installed. You can group the instances of your choice in a Config Sync Group. When you add an instance to NGINX One, you need to use a data plane key. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| | **Instance** | An instance is an individual system with NGINX installed. You can group the instances of your choice in a Config Sync Group. When you add an instance to NGINX One, you need to use a data plane key. | | |
| | **Instance** | An instance is an individual system with NGINX installed. You can group the instances of your choice in a Config Sync Group. When you add an instance to NGINX One Console, you need to use a data plane key. | |
| {{< include "/nginx-one/alert-labels.md" >}} | ||
|
|
||
|
|
||
| ## Legal notice: Licensing agreements for NGINX products |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section seems out of place. Is it necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. When I run a git blame in our now archived repo, it shows that you added this info to content/nginx-one/about.md in obsolete PR 594 back in January of 2024.
|
@ChisomUma as you can see from @travisamartin 's comments, you've uncovered some consistency issues between products. Thank you. Let me know if you need advice on how to address the comments. |
|
Hi @mjang thank you!! And yes I’ll need advice on how to address the comments. |
I've included my suggestions on the comments that you can address. |
77ca3fa to
4a43b38
Compare
mjang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more suggestion. @travisamartin and I need to resolve the discussion about where to put the legal notice.
| {{<card-section showAsCards="true" title="Glossary">}} | ||
| {{<card title="F5 NGINX Glossary" titleUrl="/glossary/glossary/" brandIcon="NGINX-product-icon.svg" isLanding="true">}} | ||
| Glossary of common terms and definitions for all F5 NGINX products. | ||
| {{</card >}} | ||
| {{</card-section>}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@travisamartin , I like @ChisomUma 's idea to set this up in a separate card for the NGINX doc index page. But I'm OK if you disagree.
Co-authored-by: Mike Jang <[email protected]>
Merged commit @mjang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert all of the bootstrap-table shortcodes to just table, and add empty lines before and after every table (separating the shortcode tags).
I recommend setting up our linting tools, because there's a few things here that will be triggered.
We also don't use horizontal lines in content anymore (---).
Hi @ADubhlaoich i have addressed this comment |
ADubhlaoich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files in the PR still have Markdown issues:
- Double line breaks
- No empty lines at the top and bottom of most tables
- No empty lines surrounding all headings
Additionally, on re-review of the content, I noticed two things:
The F5 WAF for NGINX include file is single-use. This means that there is now duplicated content at risk of drift.
The F5 WAF for NGINX page the terms were taken from should be updated to use the same include file, so there is a single source of truth.
Similarly, no include file has been created for the Kubernetes terms, which were copied from the NGINX Ingress Controller content.
Converting the content into an include file and adding it to this new page and the NGINX Ingress Controller page asserts a design pattern of creating a single source of truth for topic-specific terminology which is then embedded in two places.
…mUma/ngixdocsopensourcecontribution into consolidate-glossary-pages
Hi @ADubhlaoich I have made an attempt to fix this, I think i misunderstood the intial comment on spacing and only spaced in between tables. im happy to address any comments/feedback |
|
@ChisomUma I want to say, I admire your patience and persistence with all of these comments. Thank you! |
Proposed changes
.mdfile. The main challenge was figuring out where the new md file will live. I resolved to create a new top-level.mdfile that was referenced as a card in the main docs landing page. Attached image below:I have a question:
Checklist
Before sharing this pull request, I completed the following checklist:
Footnotes
Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩