Skip to content

Update credential watcher to allow second credential watcher #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: add-read-only-file-plugin
Choose a base branch
from

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jun 17, 2025

Proposed changes

Updated credential watcher to allow a second credential watcher to be started to monitor auxiliary command sever.

  • Credential watcher now takes a sever type to be used to determine if it is aux or command sever
  • Removed sending of CredentialUpdatedTopic from watcher plugin
  • Moved creation of new GRPC connection from watcher plugin into credential watcher when update is detected
  • CredentialUpdateMessage now has Server Type and GRPC connection

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jun 17, 2025
@aphralG aphralG requested a review from a team as a code owner June 17, 2025 09:29
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant