Skip to content

Fix remotely enabling/disabling features #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix remotely enabling/disabling features #1088

wants to merge 4 commits into from

Conversation

dhurley
Copy link
Collaborator

@dhurley dhurley commented May 23, 2025

Proposed changes

  • Add fix that prevents the agent from starting plugins more than once when features are being enabling/disabling remotely
  • Fix panic that occur when updating NGINX config
  • Add more general logging to all plugins

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this May 23, 2025
@dhurley dhurley requested a review from a team as a code owner May 23, 2025 14:58
@dhurley dhurley added the v2.x Issues and Pull Requests related to the major version v2 label May 23, 2025
@dhurley dhurley changed the title Fix remotely enabling/disabling the features Fix remotely enabling/disabling features May 23, 2025
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies enhancement New feature or request labels May 23, 2025
@dhurley dhurley mentioned this pull request May 23, 2025
Closed
6 tasks
aphralG
aphralG reviewed May 23, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@dhurley dhurley

Labels
bug Something isn't working chore Pull requests for routine tasks dependencies enhancement New feature or request v2.x Issues and Pull Requests related to the major version v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhurley @aphralG