Skip to content

Fix names and default values of Agent Config settings. #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: v3
Choose a base branch
from
Open

Fix names and default values of Agent Config settings. #1065

wants to merge 10 commits into from

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Apr 28, 2025 •
edited
Loading

Proposed changes

  • Update codeowners in metadata files
  • Add CollectionInterval to NginxRecievers and NginxPlusRecievers
  • Add defaultCollectionInterval (1 minute)
  • DefBackoffMaxInterval is now set to 10 minutes
    Renamed:
  • prometheus_exporter -> prometheus
  • otlp_exporters -> otlp
  • otlp_receivers -> otlp
  • nginx_receivers -> nginx
  • nginx_plus_receivers -> nginx_plus

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Apr 28, 2025
@aphralG aphralG marked this pull request as ready for review April 28, 2025 09:11
@aphralG aphralG requested a review from a team as a code owner April 28, 2025 09:11
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@sean-breen sean-breen sean-breen approved these changes

@john-david3 john-david3 john-david3 approved these changes

@NutsaB NutsaB NutsaB approved these changes

Assignees

@aphralG aphralG

Labels
bug Something isn't working chore Pull requests for routine tasks documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aphralG @dhurley @sean-breen @john-david3 @NutsaB