Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test fixes #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor test fixes #7

wants to merge 1 commit into from

Conversation

dipthegeezer
Copy link

Hello

Some of the tests fail due to recent work no doubt. Anyway I've fixed a bunch, still have some failures, which I'm looking into but feel free to use the commits as you see fit.

Dip

@dipthegeezer
Copy link
Author

Further comments:
Probably due to the recent refactoring some of the existing tests no longer work because functions have gone missing or been removed. eg 'start_ok', 'pg2_group_exists' are no longer in the etap.erl library hence when these tests are run we are getting stack dumps. I don't know what the plan was with these removals but the tests need to either be removed or new code added to etap.erl to test for these things?

Dip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant