Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support for domain names with multiple hyphens #502

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Fix support for domain names with multiple hyphens #502

merged 1 commit into from
Dec 4, 2024

Conversation

nfrasser
Copy link
Owner

@nfrasser nfrasser commented Dec 4, 2024

Fixes #464

@nfrasser nfrasser self-assigned this Dec 4, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12153789036

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.689%
Totals Coverage Status
Change from base Build 12153669195: 0.001%
Covered Lines: 2869
Relevant Lines: 2915
💛 - Coveralls

@nfrasser nfrasser merged commit 9183db6 into main Dec 4, 2024
4 checks passed
@nfrasser nfrasser deleted the double-hyphen branch December 4, 2024 06:06
@nfrasser nfrasser changed the title Support for domain names with two hyphens Fix support for domain names with two hyphens Dec 4, 2024
@nfrasser nfrasser changed the title Fix support for domain names with two hyphens Fix support for domain names with multiple hyphens Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nfrasser nfrasser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URLs with consecutive hyphens aren't working
2 participants
@nfrasser @coveralls