Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent delimiter apostrophes from being included in URLs #499

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

nfrasser
Copy link
Owner

@nfrasser nfrasser commented Dec 4, 2024

Fixes #488

Single quotes should end URL if encountered.

Fixes #488, should end URL if encountered.
@nfrasser nfrasser self-assigned this Dec 4, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12153217186

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 97.681%

Totals Coverage Status
Change from base Build 12153162069: -0.001%
Covered Lines: 2859
Relevant Lines: 2905

💛 - Coveralls

@nfrasser nfrasser merged commit a7629c2 into main Dec 4, 2024
4 checks passed
@nfrasser nfrasser deleted the quote-delimiter branch December 4, 2024 04:59
@nfrasser nfrasser changed the title Don't allow apostrophe in URLs Prevent delimiter apostrophes from being included in URLs Dec 4, 2024
patrickReiis added a commit to patrickReiis/linkifyjs that referenced this pull request Dec 6, 2024
This reverts commit a7629c2.
Fix: apostrophe is a valid character in a URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: linkifyStr doesn't work with apostrophe and an alphabetical character
2 participants