Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change GitHub Actions README badge #39

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

nfischer
Copy link
Owner

@nfischer nfischer commented Dec 7, 2023

This changes the README to use a standard shields.io badge for GitHub Actions. The custom badge
(https://github.com/Atrox/github-actions-badge) was cool, but the atrox.dev link doesn't work reliably. I noticed that shields has support for this now, so there's no reason to use a custom badge.

One notably difference is that this badge says the build is passing even if there's a job still in progress.

This changes the README to use a standard shields.io badge for GitHub
Actions. The custom badge
(https://github.com/Atrox/github-actions-badge) was cool, but the
atrox.dev link doesn't work reliably. I noticed that shields has support
for this now, so there's no reason to use a custom badge.

One notably difference is that this badge says the build is passing even
if there's a job still in progress.
@nfischer nfischer added the docs label Dec 7, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb9a556) 100.00% compared to head (cb5fba2) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           25        25           
=========================================
  Hits            25        25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfischer
Copy link
Owner Author

nfischer commented Dec 7, 2023

Looks like there's an issue on Windows? I'm going to run CI again based off the main branch to see if that also reproduces the issue: https://github.com/nfischer/shelljs-exec-proxy/actions/runs/7125051917

@nfischer
Copy link
Owner Author

nfischer commented Dec 7, 2023

I filed #40 to track the test failure. I'm going ahead and merging this documentation change.

@nfischer nfischer merged commit 63e5e7e into main Dec 7, 2023
28 of 42 checks passed
@nfischer nfischer deleted the doc-github-badge branch December 7, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants