Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase timeouts for flaky tests #15

Merged
merged 2 commits into from
Mar 17, 2018
Merged

Conversation

nfischer
Copy link
Owner

@nfischer nfischer commented Mar 17, 2018

This increases timeouts for the 2 flaky tests.

This also fixes a timeout issue for the "escapes quotes" test on Windows, since
we only invoked the done() callback from the unix code branch (a bug in #11).

Fixes #14

This increases timeouts for the 2 flaky tests.

Fixes #14
@nfischer nfischer added the test label Mar 17, 2018
@codecov-io
Copy link

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          23     23           
=====================================
  Hits           23     23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51a4b93...8181603. Read the comment docs.

@nfischer nfischer merged commit b809b82 into master Mar 17, 2018
@nfischer nfischer deleted the test-increase-timeout branch July 4, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase timeout for "handles unsafe filenames"
2 participants