Enable switch between light and dark mode with button #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freymaurer
requested changes
Mar 27, 2025
src/Client/Index.fs
Outdated
|
|
||
| React.useEffectOnce (fun () -> | ||
| themeChange false // Reattach event listeners manually | ||
| let storedTheme = Browser.WebStorage.localStorage.getItem("theme") |
There was a problem hiding this comment.
This should be handled by theme-change ? Because it specifically give instructions on how you could use a custom localStoragekey:
| ] | ||
| ] | ||
|
|
||
| let currentTheme, setTheme = React.useState(document.documentElement.getAttribute("data-theme")) |
There was a problem hiding this comment.
please check if all this is still required. You might have to look into "data-theme" source code for this
There was a problem hiding this comment.
We could use a toggle button, that would be an easy implementation.
Freymaurer
requested changes
Apr 1, 2025
| @@ -104,6 +104,10 @@ type React = | |||
| ) | |||
| cancel, debouncedCallBack | |||
|
|
|||
| static member inline useLocalStorage<'A>(func: (string * 'A) -> ('A * ('A -> unit)), key: string, defaultValue: 'A) = | |||
| let useLocalStorage: (string * 'A) -> ('A * ('A -> unit)) = func | |||
There was a problem hiding this comment.
maybe put the import here? 😅
There was a problem hiding this comment.
Fable that you must not do that.
error FABLE: importMember must be assigned to a variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #658