Lower java source version & jvm target to 1.8, close #187

Signed-off-by: Shengqi Chen <[email protected]>
nfcim · Dec 20, 2024 · 49ef9b0 · 49ef9b0
1 parent 3a3164d
commit 49ef9b0
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -185,5 +185,5 @@
   * More elegant exception handling (#169)
 * Bump tool versions & dependencies of Android plugin and example app:
   * Related issues / PRs: #179 #184, #186, #187
-  * Now using Java 17, Gradle 8.9, MinSDKVer 26, AGP 8.7, Kotlin 2.1.0
+  * Now requiring Java 17, Gradle 8.9, MinSDKVer 26, AGP 8.7, Kotlin 2.1.0
 * Bump dependencies of iOS plugin (minimum is now iOS 12.0)
diff --git a/README.md b/README.md
@@ -29,9 +29,9 @@ This library uses [ndef](https://pub.dev/packages/ndef) for NDEF record encoding
 
 We have the following minimum version requirements for Android plugin:
 
+* Java 17
 * Gradle 8.9
-* Java 17 (for compiling, see [Gradle doc](https://docs.gradle.org/current/userguide/toolchains.html))
-* Android SDK 26
+* Android SDK 26 (you must set corresponding `jvmTarget` in you app's `build.gradle`)
 * Android Gradle Plugin 8.7
 
 To use this plugin on Android, you also need to:

diff --git a/android/build.gradle b/android/build.gradle
@@ -22,12 +22,12 @@ android {
     compileSdk 35
 
     compileOptions {
-        sourceCompatibility JavaVersion.VERSION_17
-        targetCompatibility JavaVersion.VERSION_17
+        sourceCompatibility JavaVersion.VERSION_1_8
+        targetCompatibility JavaVersion.VERSION_1_8
     }
 
     kotlinOptions {
-        jvmTarget = JavaVersion.VERSION_17
+        jvmTarget = JavaVersion.VERSION_1_8
     }
 
     sourceSets {

diff --git a/example/android/app/build.gradle b/example/android/app/build.gradle
@@ -30,8 +30,12 @@ android {
     compileSdk 35
 
     compileOptions {
-        sourceCompatibility JavaVersion.VERSION_17
-        targetCompatibility JavaVersion.VERSION_17
+        sourceCompatibility JavaVersion.VERSION_1_8
+        targetCompatibility JavaVersion.VERSION_1_8
+    }
+
+    kotlinOptions {
+        jvmTarget = JavaVersion.VERSION_1_8
     }
 
     sourceSets {
@@ -64,5 +68,4 @@ flutter {
 }
 
 dependencies {
-    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$KotlinVersion"
 }