Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling Cards Blog Post #2646

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Calling Cards Blog Post #2646

merged 11 commits into from
Jul 17, 2024

Conversation

cmatKhan
Copy link
Contributor

This is the much anticipated Calling Cards blog post.

I also adjusted the README instructions on launching the dev server to more explicitly describe the procedure I followed -- that isn't related to the calling cards blog and might be better done in a different push.

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 40d05ef
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/669787a458bf980008bee86f
😎 Deploy Preview https://deploy-preview-2646--nf-core-main-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
just some smaller things (commit with fixes for the figures is incoming).

README.md Outdated Show resolved Hide resolved
@cmatKhan
Copy link
Contributor Author

@mashehu thank you for your commits and review.

I removed the README update from this branch, updated the background, accepted your commits and made some minor text edits.

I'm failing the playwright check now -- I'm running this on my local and it seems like it is failing on pages other than the one i updated.

@cmatKhan cmatKhan requested a review from mashehu July 14, 2024 17:18
@mashehu
Copy link
Contributor

mashehu commented Jul 14, 2024

Yes, I hoped the playwright tests would work better with the new monorepo structure, but we haven't found a good way to handle the multiple deployment previews. The tests can be ignored for now.

@mashehu
Copy link
Contributor

mashehu commented Jul 17, 2024

okay, good to merge whenever you are ready 🙂

@FriederikeHanssen
Copy link
Contributor

The deploy preview looks off (tested on chrome and safari). Is this anythign to be concerned about @mashehu
Screenshot 2024-07-17 at 11 33 42

@mashehu
Copy link
Contributor

mashehu commented Jul 17, 2024

Will be fine once it's merged (bug with the new setup and different sources for components)

@mashehu
Copy link
Contributor

mashehu commented Jul 17, 2024

@cmatKhan I set the pubDate now to July 18th midnight. feel free to change that to a date more suitable for you (just want to have the "new blog post" indicator appear for this post as well (stays there for 24h past release)

@cmatKhan cmatKhan merged commit 0e77de1 into nf-core:main Jul 17, 2024
7 of 8 checks passed
@cmatKhan cmatKhan deleted the callingcards_intro branch July 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants