Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change management section to regulatory docs #2833

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

atrigila
Copy link
Contributor

@atrigila atrigila commented Oct 30, 2024

Expand change management section explaining how nf-core handles PRs.

@netlify /docs/guidelines/regulatory/overview

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 19fe045
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/672214da6051a30008eccd33
😎 Deploy Preview https://deploy-preview-2833--nf-core-main-site.netlify.app/docs/guidelines/regulatory/overview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@tomiles tomiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I'm not sure how specific we want to go as specific for the Change Management section, some items seem more in the category of "nice to have" but are not really a regulatory necessity.

(added some small fixes so we consistently use main branch as the primary branch label.)

@github-actions github-actions bot deleted a comment from netlify bot Oct 30, 2024
@apeltzer
Copy link
Member

@nf-core-bot fix linting

@apeltzer
Copy link
Member

@nf-core-bot fix linting

@atrigila
Copy link
Contributor Author

Thanks for your feedback, you are right, I added a small note on how this relates to re-validation of pipelines.

@apeltzer apeltzer merged commit c4fb948 into nf-core:main Oct 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants