-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling Cards Blog Post #2646
Calling Cards Blog Post #2646
Conversation
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
just some smaller things (commit with fixes for the figures is incoming).
sites/main-site/src/assets/images/blog/callingcards/callingcards_vs_chip.png
Outdated
Show resolved
Hide resolved
remove 'to' Co-authored-by: Matthias Hörtenhuber <[email protected]>
add italics to s.cerevisiae Co-authored-by: Matthias Hörtenhuber <[email protected]>
remove double 'the' Co-authored-by: Matthias Hörtenhuber <[email protected]>
'the currently' to 'current'y Co-authored-by: Matthias Hörtenhuber <[email protected]>
capitalize BED Co-authored-by: Matthias Hörtenhuber <[email protected]>
…te from this branch; minor edits to text
5c216da
to
cb8fe6a
Compare
@mashehu thank you for your commits and review. I removed the README update from this branch, updated the background, accepted your commits and made some minor text edits. I'm failing the playwright check now -- I'm running this on my local and it seems like it is failing on pages other than the one i updated. |
Yes, I hoped the playwright tests would work better with the new monorepo structure, but we haven't found a good way to handle the multiple deployment previews. The tests can be ignored for now. |
okay, good to merge whenever you are ready 🙂 |
The deploy preview looks off (tested on chrome and safari). Is this anythign to be concerned about @mashehu |
Will be fine once it's merged (bug with the new setup and different sources for components) |
@cmatKhan I set the |
This is the much anticipated Calling Cards blog post.
I also adjusted the README instructions on launching the dev server to more explicitly describe the procedure I followed -- that isn't related to the calling cards blog and might be better done in a different push.