Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Krešimir Beštak's new feature: markersheet columns can be in any order #72

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

RobJY
Copy link
Contributor

@RobJY RobJY commented Jan 3, 2025

Co-authored-by: Krešimir Beštak [email protected]

Markersheet columns can be in any order.

Nice idea to grab the schema and make a map. Thanks!

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Working through these remaining checklist tasks

Maybe we should use the same idea for the samplesheets?

@RobJY RobJY self-assigned this Jan 3, 2025
@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@RobJY
Copy link
Contributor Author

RobJY commented Jan 13, 2025

Hi @kbestak, when I started putting together this PR I was able to reproduce the error you mentioned, but that's no longer the case. Could you please provide a sample and marker sheet pair that cause the error when run on the dev branch?
@jmuhlich has pointed out that the updated nf-validation code should be able to handle any order for the input sheet columns and this seem to be working well. Maybe there was another issue causing the error you saw that has since been corrected?
Thanks for your help with this.

@kbestak
Copy link
Contributor

kbestak commented Jan 18, 2025

This looks good regarding the marker sheet definition and backsub validation. I'm not entirely sure which error you're referencing to, if it's the default segmentation running on only ASHLAR outputs, that was fixed with the post_registation channel definition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants