Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL2: metagenomics #1019

Merged
merged 164 commits into from
Sep 3, 2024
Merged

DSL2: metagenomics #1019

merged 164 commits into from
Sep 3, 2024

Conversation

ilight1542
Copy link

@ilight1542 ilight1542 commented Aug 7, 2023

TODOS:

  • Ensure files passed to metagenomics profiling are identifiable with outputted names (eg should be able to distinguish mapped, vs unmapped to ref (if user selects 'all': do we want to merge these and just use the raw sequencing reads --> this i think is the expected behavior but not always working?)
  • Finish testing for maltextract @merszym
  • Finish testing of various input parameters to ensure proper behavior for outputted files (ensure no overwriting of files is occurring with ext.prefix (!!)
  • Test malt parallel execution (multiple independent submissions)
  • Test warning and parameter combo checks implemented in eager.nf
  • Add any necessary warnings or errors for parameter combos for metagenomics to eager.nf
  • Double check documentation is correct, and easy to understand
  • Check how single-strand vs double strand mixed input into malt currently behaves -- currently does not flag singlestranded if one sample is singlestranded (this info may be wiped from metamap at mapping step?). Need to check for single sample(!)
  • Update that malt keeps Single stranded library prep info for later use in maltextract

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

ilight1542 and others added 30 commits March 29, 2023 11:44
from PR review

Co-authored-by: James A. Fellows Yates <[email protected]>
from PR review

Co-authored-by: James A. Fellows Yates <[email protected]>
…_classification

Unify metagenomic implemenations into development dsl2-metagenomics branch

NOTE: still under development
- WIP: prepare kraken input channel
This commit completes the krakenuniq workflow, tested with the test
profile.
Other classifiers not yet touched!
@merszym
Copy link

merszym commented Aug 16, 2024

@jfy133 @ilight1542 All remaining issues are fixed/documented/updated :)

@merszym merszym requested a review from jfy133 August 16, 2024 11:39
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some small code clean up that can be done/addressed in a future PR but otherwise this looks good to me to get it in and start fixing everything else in smaller follow up PRs (assuming tests are passing)

@jfy133
Copy link
Member

jfy133 commented Sep 2, 2024

@nf-core-bot fix linting

@merszym merszym merged commit 56718ff into dev Sep 3, 2024
18 checks passed
@merszym merszym deleted the dsl2-metagenomics branch September 3, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants