-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSL2: metagenomics #1019
DSL2: metagenomics #1019
Conversation
from PR review Co-authored-by: James A. Fellows Yates <[email protected]>
from PR review Co-authored-by: James A. Fellows Yates <[email protected]>
…//github.com/ilight1542/eager into dsl2_subworkflow_metagenomics_classification
…_classification Unify metagenomic implemenations into development dsl2-metagenomics branch NOTE: still under development
…into dsl2-metagenomics
- WIP: prepare kraken input channel
This commit completes the krakenuniq workflow, tested with the test profile. Other classifiers not yet touched!
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
@jfy133 @ilight1542 All remaining issues are fixed/documented/updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some small code clean up that can be done/addressed in a future PR but otherwise this looks good to me to get it in and start fixing everything else in smaller follow up PRs (assuming tests are passing)
@nf-core-bot fix linting |
TODOS:
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).