Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update daisybio profile: use group of the launch directory for work directory #811

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

JohannesKersting
Copy link
Contributor

@JohannesKersting JohannesKersting commented Dec 3, 2024


name: daisybio profile update
about: use group of the launch directory for work directory

Our profile creates all work directories in a centralized location. Currently, this work directory will belong to the group of the user launching the pipeline. As a consequence, only this user will be able to use Nextflow's resume feature.

This update sets the group of the work directory (and group special permission) to the group of the launch directory to allow all users in a shared group project to access the work directory and use the resume feature.

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

Copy link
Contributor

@nictru nictru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much needed :D

@JohannesKersting
Copy link
Contributor Author

Do I need to be worried about the failed github actions?
Don't think they relate to the change in this pull request.

@nictru
Copy link
Contributor

nictru commented Dec 4, 2024

The issue is that the actions are trying to utilize the latest nextflow 24.11-edge, which requires Java 17 or later, but somehow the environment sticks to Java 11

@nictru
Copy link
Contributor

nictru commented Dec 4, 2024

@maxulysse is working on a repo-wide fix similar to this

@maxulysse
Copy link
Member

@maxulysse is working on a repo-wide fix similar to this

#813

@JohannesKersting JohannesKersting merged commit 304c9e4 into nf-core:master Dec 4, 2024
138 checks passed
@JohannesKersting JohannesKersting deleted the update_daisybio branch December 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants