-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New config profile KAUST #809
Conversation
conf/kaust.config
Outdated
} | ||
|
||
// Keep work directory after a successful run | ||
cleanup = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be wary of this, if users don't clean up their work directories manually and regularly, you may have very filled up hard drives very quickly
Nf-core pipelines come with a debug profile that can turn this off if necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the note, I have now removed this flag. I thought to keep the decision to the user!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to keep it,= true actually,
Default is set to false!
conf/kaust.config
Outdated
// Use existing images from the centralized library, if available | ||
libraryDir = "/biocorelab/BIX/resources/singularity/images/" | ||
// Download images that are missing from the library to user space | ||
cacheDir = "/home/$USER/.singularity/nf_images/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check this works and nextflow doesn't try to resolve the variable [rather than bash] (this can happen in some of the config sections)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And does the cache directory already exist for all users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already tested this and it works :)
yes, it will automatically create the cache directory if it doesn't exist
Sorry @husensofteng I didn't see you were waiting for test execution approval. So you don't need to wait next time, feel free to join the nf-core GitHub org as described on https://nf-co.re/join |
thank you, I just sent a request! |
} | ||
|
||
// Load genome resources and assets hosted by the Bioinformatics team on IBEX cluster | ||
includeConfig '/biocorelab/BIX/resources/configs/genomes.yaml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfy133 the profile does not recognize this statement, do you you have any suggestion how to make it work?
The purpose is to host a custom set of genome resources (similar to igenomes but locally maintained).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think users would have to specify it with a custom config i.e. with -c
... @maxulysse any ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortauntely this is breaking other pipeliens, so I'm commenting it out ofr now here: #810
name: New Config for KAUST
about: A new cluster config for KAUST Ibex cluster
Please follow these steps before submitting your PR:
[WIP]
in its titlemaster
branchSteps for adding a new config profile:
conf/
directorydocs/
directorynfcore_custom.config
file in the top-level directoryREADME.md
file in the top-level directoryprofile:
scope in.github/workflows/main.yml
.github/CODEOWNERS
(**/<custom-profile>** @<github-username>
)The purpose of this new config is to help users on the KAUST Ibex cluster to run nf-core workflows smoothly.
Thank you!