-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color tree by measurements #1819
Comments
I chatted with @tkanderson today at Options and he upvoted this feature request as high priority for their work. He is interested in the full nextflu functionality where the tree can display the raw measurements and imputed titer values per reference strain. |
We had a small group meeting today that went over the design questions (meeting notes). Summary of v0: Clicking on a single measurements row will inject a dynamic color-by. The color scale will be based on the 5-95 percentile of all values in the single measurements collection so that outliers don't skew the coloring. This is based on all measurements instead of just measurements in the current row to ensure the color scale is stable when switching between rows. Each strain's color will be based on the mean of the strain's measurements in the selected row. Strains without measurements values will be greyed out. If the grouping value is a tip in the tree (i.e. a reference strain), we will use a grey/black crosshair icon to highlight the reference. No special functionality will be added for titers from models, they can just be added as a separate measurements collection. Things left for future versions:
|
I think the cleanest path for this would be to update Another thing that I'm considering is refactoring where the measurements are being filtered and grouped. This is currently happening within the front-end MeasurementPlot component, which made sense when I first implemented the measurements panel since this was the only component that needed the grouped measurements. However, since the grouped measurements is needed for the coloring calculations, it would make more sense for this data to be in the central Redux state. This is especially true when we want to add URL params for measurements colorings in the future. |
Description
Originally suggested by @trvrb on Slack:
This feature is part of a class of features that would allow the measurements panel to control the display of other panels. This specific feature would function like a combination of 1) a filter to all tips in the tree that appear as test viruses in the selected row(s) and 2) a dynamically-defined coloring of tips (and the map and frequencies) by a quantitative color scale corresponding to the range of measurements in the selected row(s).
This functionality would be analogous to the nextflu implementation of gears that users can click on to display only tips that have measurements against that reference.
Design questions
The text was updated successfully, but these errors were encountered: