feat(config): add max-fail option to configuration file #2063
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
+ Coverage 79.97% 80.05% +0.08%
==========================================
Files 102 102
Lines 23997 24117 +120
==========================================
+ Hits 19192 19308 +116
- Misses 4805 4809 +4 ☔ View full report in Codecov by Sentry. |
Jayllyz
force-pushed
the
feat/config-max-fail
branch
2 times, most recently
from
f1bbf32 to
55932a2
Compare
nextest-runner/default-config.toml
Outdated
| # "max-fail" defines the maximum number of test failures that are allowed before test execution is stopped. | ||
| max-fail = 1 |
There was a problem hiding this comment.
So I think this should actually be part of the fail-fast field. This field currently supports true or false, but it should also support
fail-fast = { max-fail = 1 }This addresses issues like precedence, and matches the CLI behavior where --fail-fast and --max-fail=1 cannot be specified together.
There was a problem hiding this comment.
Makes sense, Im going to try to do it
| @@ -83,4 +130,126 @@ mod tests { | |||
| MaxFail::from_str(input).expect_err(&format!("expected input '{input}' to fail")); | |||
| } | |||
| } | |||
|
|
|||
| #[test_case( | |||
There was a problem hiding this comment.
These tests are fantastic, thank you!
|
Tested the config on one of my rust repo, it's working good. |
sunshowers
force-pushed
the
feat/config-max-fail
branch
from
7a022a9 to
d3f1eff
Compare
|
I've combined max-fail and fail-fast into a single struct, and added tests for error messages (i.e. not just that there are errors). |
sunshowers
force-pushed
the
feat/config-max-fail
branch
from
d3f1eff to
18946d0
Compare
sunshowers
force-pushed
the
feat/config-max-fail
branch
from
18946d0 to
229ab71
Compare
Closes #1944