Pass in --filter-platform to cargo metadata #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
==========================================
+ Coverage 78.37% 78.47% +0.10%
==========================================
Files 74 75 +1
Lines 17934 18076 +142
==========================================
+ Hits 14056 14186 +130
- Misses 3878 3890 +12 ☔ View full report in Codecov by Sentry. |
There's no real point delaying these -- turns out we need them at the start of the program anyway.
We're basically always going to need the build platforms anyway, so just construct it immediately at startup.
sunshowers
force-pushed
the
cargo-metadata-filter
branch
from
df0dc20 to
f6e1021
Compare
sunshowers
commented
Apr 23, 2024
This ensures that unnecessary dependencies aren't fetched.
sunshowers
force-pushed
the
cargo-metadata-filter
branch
from
f6e1021 to
1439087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required a surprising amount of rejiggering, but ended up paying off a lot of tech debt. I realized that now that we're passing in frozen/locked/offline, we'd better not cause excessive downloads due to platforms.
However, extra downloads compared to
cargo testcan still happen because nextest currently asks for data about all features. I think changing this may not be possible due to #1402. We're likely going to need graph metadata about all features in #1402, in order to make decisions about what to really build.TODO:
Fixes #1298.