fix(client): remove duplication of views in views/all_views #1228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduced in #843 and discovered in this help thread, the new implementation for retrieving views via the client has duplicated views with multiple components.
This is due to removing the construction of a dictionary internally to make the list unqiue. This PR adds this method back and comments
it to ensure this isn't wrongly removed again.
With the following code, running
send_view
twice, andall_views
once returns 4 views when it should be 2 unique, as seen in the new behaviour below.This is a Code Change
task pyright
and fixed the relevant issues.