-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IPInfo as secondary source #2683
Conversation
Fix #2682 Signed-off-by: Daniel Hansson <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
Hmm, this doesn't seem to work. Allowing "SE" in the list still blocks it when trying to reach the site. @abdullahdevrel Are your |
Example from CSV:
In the Apache conf, we use different "tags". This might not work after all? |
So, since IPInfo doesn't run it's own Apache module, I'm afraid this won't work. :| |
@enoch85 Thank you for reviewing. The scheme is different from MaxMind's, and you have found the post that I would have linked. I believe the Apache module (https://github.com/maxmind/mod_maxminddb) is schema agnostic, like all the other MMDB reader libraries out there (https://community.ipinfo.io/t/list-of-mmdb-reader-libraries/2821). Looking at this bit of code: Lines 224 to 227 in 6a111c7
So, with respect to our database schema, I assume this will be:
Can you see if it would work? |
Yes, I can confirm, the change works. Now I need to get my head around how we want to do this... |
Found a solution!
|
Signed-off-by: Daniel Hansson <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
OK, so this is tested and works! @abdullahdevrel Please confirm that the "attribution requirements" are enough. |
Signed-off-by: Daniel Hansson <[email protected]>
Signed-off-by: Daniel Hansson <[email protected]>
Fix #2682