Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NC 23 #562

Closed
jurgenhaas opened this issue Dec 1, 2021 · 27 comments
Closed

Add support for NC 23 #562

jurgenhaas opened this issue Dec 1, 2021 · 27 comments

Comments

@jurgenhaas
Copy link

The app store at https://apps.nextcloud.com/apps/user_saml doesn't show support for NC 23 yet, are you planning to support that platform?

@solracsf

This comment has been minimized.

@l00ptr

This comment has been minimized.

@fwininger

This comment has been minimized.

@solracsf

This comment has been minimized.

@nickvergessen

This comment has been minimized.

@fschrempf

This comment was marked as off-topic.

@Buri

This comment has been minimized.

@peacepenguin

This comment was marked as off-topic.

@fschrempf
Copy link
Contributor

I thought "Featured" apps in the store were vetted and confirmed to be working before a major release?

Unfortunately, it seems like this is not the case. One would expect this, but there are other "featured" apps (e. g. groupfolders) that have "missed" major releases and where it took several weeks for the app developers to catch up. I would really like to see some plan/strategy to prevent this, but I also see how the current structure makes it rather difficult for the developers to handle this.

@peacepenguin
Copy link

Perhaps core functionality like SAML/SSO shouldn't be an app at all? This should simply be integrated into the server code itself. Just like FIDO2 and two factor auth have become integrated now.

Especially considering the saml app lives under the official nextcloud organization in github. That gives the illusion that its not just a 3rd party app, but actually maintained by Nextcloud as a company/organization.

Bizarre that nextcloud advertises saml/sso as a core feature, but then it's actually "just an app" that might not even work at all if you happened to deploy a new server today, based in the current download links, you would be surprised to see SAML not available.

@fschrempf
Copy link
Contributor

@peacepenguin I fully agree. We were having a similar discussion about integration into the core for the groupfolders app here: nextcloud/groupfolders#1215 (comment).

And here is the same situation (release delayed) for the groupfolders app and NC22: nextcloud/groupfolders#1598.

Just for reference. Let's not go too far off topic here... ;)

@benhartwich
Copy link

Has anyone tried the upgrade with the current version? Is there any problem, which prohibits updating although it is not officially supported?

@peacepenguin
Copy link

@benhartwich yes I've enabled SAML manually again as an "Untested app" from the app store after the upgrade to 23 disabled it as incompatible, seems to work fine for us in our deployment.

@keithjnewman

This comment has been minimized.

@rhclayto

This comment has been minimized.

@jannislehmann
Copy link

The workaround from @peacepenguin works fine for the time-being. You can also use the occ cli to re-enable the app.
This will at least allow you to log-in again.

@rhclayto
Copy link

rhclayto commented Dec 24, 2021

The workaround from @peacepenguin works fine for the time-being. You can also use the occ cli to re-enable the app. This will at least allow you to log-in again.

Cli enabling worked, but note to others, you have to manually edit the app's info.xml file:

<nextcloud min-version="21" max-version="22" />

must be changed to

<nextcloud min-version="21" max-version="23" />

or else you get App "SSO & SAML authentication" cannot be installed because it is not compatible with this version of the server..

@faust64
Copy link

faust64 commented Jan 1, 2022

Code in master seems to be ready for NC23, since June 29th
c36dc6d

Any reason to hold on a release?

@wwwwiii

This comment was marked as resolved.

@blizzz
Copy link
Member

blizzz commented Jan 12, 2022

Any update regarding this?

Please have an eye on the app store. Once it is releases, it will be there.

@luclu
Copy link

luclu commented Feb 4, 2022

Unfortunately and suprisingly I found Nextcloud 23.0.1 not working with the current version of user_saml.

occ app:enable user_saml
--> App "SSO & SAML authentication" cannot be installed because it is not compatible with this version of the server.

Is there anything I can do to help - like incrementing the supported version field?

Eventually installing as untested app will work though.

@josephcsible
Copy link

@luclu Use occ app:enable -f user_saml to do that.

@RayChimera

This comment was marked as off-topic.

@edmundlaugasson
Copy link

Proposed to add that feature into Nextcloud core, so we won't need any additional app anymore.

@small1
Copy link

small1 commented Feb 17, 2022

Proposed to add that feature into Nextcloud core, so we won't need any additional app anymore.

This is happening to a few apps now and then that is more or less considered enterprise. They will be ready when they release the enterprise part of 23. And that can take a while. Groupfolders had the same last year.

And if you have a big enough environment ... perhaps going to 23 might be a bit early still.

@nextcloud nextcloud locked as too heated and limited conversation to collaborators Feb 21, 2022
@solracsf solracsf pinned this issue Feb 21, 2022
@PVince81
Copy link
Member

PVince81 commented Mar 4, 2022

there will be upcoming config format changes: #558

after that we can mark the app as compatible with 23 and release it

the PR is reaching completion and needs further testing, feel free to help out

@blizzz blizzz unpinned this issue Apr 11, 2022
@AndyScherzinger
Copy link
Member

@nextcloud nextcloud unlocked this conversation Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests