-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NC 23 #562
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
This comment was marked as off-topic.
This comment was marked as off-topic.
Unfortunately, it seems like this is not the case. One would expect this, but there are other "featured" apps (e. g. groupfolders) that have "missed" major releases and where it took several weeks for the app developers to catch up. I would really like to see some plan/strategy to prevent this, but I also see how the current structure makes it rather difficult for the developers to handle this. |
Perhaps core functionality like SAML/SSO shouldn't be an app at all? This should simply be integrated into the server code itself. Just like FIDO2 and two factor auth have become integrated now. Especially considering the saml app lives under the official nextcloud organization in github. That gives the illusion that its not just a 3rd party app, but actually maintained by Nextcloud as a company/organization. Bizarre that nextcloud advertises saml/sso as a core feature, but then it's actually "just an app" that might not even work at all if you happened to deploy a new server today, based in the current download links, you would be surprised to see SAML not available. |
@peacepenguin I fully agree. We were having a similar discussion about integration into the core for the groupfolders app here: nextcloud/groupfolders#1215 (comment). And here is the same situation (release delayed) for the groupfolders app and NC22: nextcloud/groupfolders#1598. Just for reference. Let's not go too far off topic here... ;) |
Has anyone tried the upgrade with the current version? Is there any problem, which prohibits updating although it is not officially supported? |
@benhartwich yes I've enabled SAML manually again as an "Untested app" from the app store after the upgrade to 23 disabled it as incompatible, seems to work fine for us in our deployment. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The workaround from @peacepenguin works fine for the time-being. You can also use the occ cli to re-enable the app. |
Cli enabling worked, but note to others, you have to manually edit the app's info.xml file:
must be changed to
or else you get |
Code in master seems to be ready for NC23, since June 29th Any reason to hold on a release? |
This comment was marked as resolved.
This comment was marked as resolved.
Please have an eye on the app store. Once it is releases, it will be there. |
Unfortunately and suprisingly I found Nextcloud 23.0.1 not working with the current version of user_saml.
Is there anything I can do to help - like incrementing the supported version field? Eventually installing as untested app will work though. |
@luclu Use |
This comment was marked as off-topic.
This comment was marked as off-topic.
Proposed to add that feature into Nextcloud core, so we won't need any additional app anymore. |
This is happening to a few apps now and then that is more or less considered enterprise. They will be ready when they release the enterprise part of 23. And that can take a while. Groupfolders had the same last year. And if you have a big enough environment ... perhaps going to 23 might be a bit early still. |
there will be upcoming config format changes: #558 after that we can mark the app as compatible with 23 and release it the PR is reaching completion and needs further testing, feel free to help out |
App has been released now, see https://apps.nextcloud.com/apps/user_saml / https://github.com/nextcloud/user_saml/releases/tag/v5.0.0 |
The app store at https://apps.nextcloud.com/apps/user_saml doesn't show support for NC 23 yet, are you planning to support that platform?
The text was updated successfully, but these errors were encountered: