Add PHPUnit workflow, fix path handling bug, REUSE/php-cs compliance by Copilot · Pull Request #722 · nextcloud/updater

Copilot · 2026-03-25T06:09:39Z

Add .github/workflows/phpunit.yml
Fix moveWithExclusions() explode path bug + add issue Copy error when trying to update 32.0.5 -> 32.0.6 #711 regression tests
Fix REUSE: add vendor-bin/phpunit/** annotation to REUSE.toml
Fix php-cs: reformat string concatenation in tests/unit/UpdaterTest.php to leading-dot style
Verify same-code-check still passes
Resolve merge conflicts with origin/master (kept opcache_invalidate fix from master + buildPath() from our branch)
Drop testRelativePathExtractionForIssue711() — pure logic test that doesn't instantiate the Updater class

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

… createBackup() Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/5f2df1e7-e17a-4242-b4c3-91a831b9048d

…cloud/privacy pattern Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/5f2df1e7-e17a-4242-b4c3-91a831b9048d

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/f6fad36e-0af0-4aee-b04b-3faae41f45f3

#711 regression tests Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/f6fad36e-0af0-4aee-b04b-3faae41f45f3

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/cf8949f9-d766-48cd-b56c-ec8643d0cbc4

Keeper-of-the-Keys · 2026-03-26T06:19:35Z

Hey @skjnldsv
The substr based approach to #711/#720 should also work, my only gripe (probably overly paranoid) with it is that it is (as currently implemented) just chopping of a set amount of characters without verifying that they actually are what we seek to remove.

Keeper-of-the-Keys · 2026-03-26T11:22:23Z

As a total aside - how wise is it to roll so many issues into 1 PR?

skjnldsv · 2026-05-07T07:08:22Z

As a total aside - how wise is it to roll so many issues into 1 PR?

Well, this adds phpunit tests which was not enabled before, so it will definitely be a big PR.
That is still a thing we should have :)

skjnldsv · 2026-05-07T07:08:25Z

@copilot resolve the merge conflicts in this pull request

…+ buildPath() Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/a9abb800-8545-4e95-a29f-29e8dbd26cdf Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>

Copilot · 2026-05-07T07:12:47Z

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in 851f344. The only conflict was in index.php and lib/Updater.php — master added opcache_invalidate() to the version file check while our branch replaced the path with buildPath(). Both changes are preserved in the merge.

Keeper-of-the-Keys · 2026-05-07T07:20:38Z

As a total aside - how wise is it to roll so many issues into 1 PR?

Well, this adds phpunit tests which was not enabled before, so it will definitely be a big PR. That is still a thing we should have :)

My point was that adding phpunit and fixing #711/#720 should be 2 different PRs.

…er class Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/28c7bc95-7a60-4f58-9fe9-27fc9d5f3143 Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>

Initial plan

e2b91df

Copilot AI assigned Copilot and skjnldsv Mar 25, 2026

Copilot started work on behalf of skjnldsv March 25, 2026 06:09 View session

Copilot AI and others added 2 commits March 25, 2026 06:36

feat: add buildPath() method to Updater class and fix double-slash in…

f911adb

… createBackup() Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/5f2df1e7-e17a-4242-b4c3-91a831b9048d

refactor: move phpunit to dedicated vendor-bin/phpunit following next…

bba59b1

…cloud/privacy pattern Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/5f2df1e7-e17a-4242-b4c3-91a831b9048d

Copilot AI changed the title ~~[WIP] Add string concat method for nextcloudDir concatenations~~ feat: add buildPath() helper and fix double-slash bug in createBackup() Mar 25, 2026

Copilot AI requested a review from skjnldsv March 25, 2026 06:47

Copilot finished work on behalf of skjnldsv March 25, 2026 06:47

Copilot started work on behalf of skjnldsv March 25, 2026 06:47 View session

Copilot AI and others added 2 commits March 25, 2026 06:53

plan: fix moveWithExclusions explode and add #711 regression tests

150f192

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/f6fad36e-0af0-4aee-b04b-3faae41f45f3

fix: replace explode() with substr() in moveWithExclusions(); add issue

dc688b2

#711 regression tests Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/f6fad36e-0af0-4aee-b04b-3faae41f45f3

Copilot AI changed the title ~~feat: add buildPath() helper and fix double-slash bug in createBackup()~~ fix: centralise path building, fix explode-based double-slash bug (issue #711), add PHPUnit Mar 25, 2026

Copilot finished work on behalf of skjnldsv March 25, 2026 06:57

skjnldsv requested a review from blizzz March 25, 2026 08:16

skjnldsv mentioned this pull request Mar 25, 2026

fix: add trailing slash to nextcloudDir to fix #711 #720

Open

skjnldsv marked this pull request as ready for review March 25, 2026 08:16

skjnldsv requested a review from Altahrim as a code owner March 25, 2026 08:16

Copilot started work on behalf of skjnldsv March 25, 2026 08:18 View session

Copilot AI and others added 2 commits March 25, 2026 08:24

plan: fix reuse, php-cs, and same-code-check issues

275e3d2

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/cf8949f9-d766-48cd-b56c-ec8643d0cbc4

fix: REUSE compliance (vendor-bin/phpunit), php-cs concatenation style

700e960

Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com> Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/cf8949f9-d766-48cd-b56c-ec8643d0cbc4

Copilot AI changed the title ~~fix: centralise path building, fix explode-based double-slash bug (issue #711), add PHPUnit~~ Add PHPUnit workflow, fix path handling bug, REUSE/php-cs compliance Mar 25, 2026

Copilot finished work on behalf of skjnldsv March 25, 2026 08:29

Copilot started work on behalf of skjnldsv May 7, 2026 07:08 View session

merge: resolve conflicts with origin/master; keep opcache_invalidate …

851f344

…+ buildPath() Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/a9abb800-8545-4e95-a29f-29e8dbd26cdf Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>

Copilot finished work on behalf of skjnldsv May 7, 2026 07:13

blizzz reviewed May 7, 2026

View reviewed changes

Comment thread tests/unit/UpdaterTest.php Outdated

Copilot started work on behalf of skjnldsv May 7, 2026 07:23 View session

test: drop pure-logic regression test that doesn't test against Updat…

dfae2d2

…er class Agent-Logs-Url: https://github.com/nextcloud/updater/sessions/28c7bc95-7a60-4f58-9fe9-27fc9d5f3143 Co-authored-by: skjnldsv <14975046+skjnldsv@users.noreply.github.com>

Copilot finished work on behalf of skjnldsv May 7, 2026 07:25

Copilot started work on behalf of skjnldsv May 7, 2026 07:28 View session

Copilot finished work on behalf of skjnldsv May 7, 2026 07:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PHPUnit workflow, fix path handling bug, REUSE/php-cs compliance#722

Add PHPUnit workflow, fix path handling bug, REUSE/php-cs compliance#722
Copilot wants to merge 9 commits into
masterfrom
copilot/add-string-concat-method

Copilot AI commented Mar 25, 2026 •

edited

Loading

Uh oh!

Keeper-of-the-Keys commented Mar 26, 2026

Uh oh!

Keeper-of-the-Keys commented Mar 26, 2026

Uh oh!

skjnldsv commented May 7, 2026

Uh oh!

skjnldsv commented May 7, 2026

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Uh oh!

Keeper-of-the-Keys commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Keeper-of-the-Keys commented Mar 26, 2026

Uh oh!

Keeper-of-the-Keys commented Mar 26, 2026

Uh oh!

skjnldsv commented May 7, 2026

Uh oh!

skjnldsv commented May 7, 2026

Uh oh!

Copilot AI commented May 7, 2026

Uh oh!

Uh oh!

Keeper-of-the-Keys commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Mar 25, 2026 •

edited

Loading