Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable19] IE11 madness #1036

Merged
merged 6 commits into from
Sep 14, 2020
Merged

[stable19] IE11 madness #1036

merged 6 commits into from
Sep 14, 2020

Conversation

juliushaertl
Copy link
Member

  • Backport of Yet another IE11 fixing round #1032
  • Additionally downgrade core-js since for some reason this version causes issues with String.split with the regex that is used by prosemirror-model where "block+".split(/\s*(?=\b|\W|$)/) would return ["b", "l", "o", "c", "k", "+"] instead of ["block+"]
    However the exact same version combinations work fine on master, so I assume there are some wild polyfills overriding each other

Related issue for core-js zloirock/core-js#810

Otherwise we need to keep up with each dependency if it is actually IE11 compatible

Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Sep 11, 2020
@juliushaertl juliushaertl added this to the Nextcloud 19.0.4 milestone Sep 11, 2020
@juliushaertl juliushaertl merged commit cd0ef16 into stable19 Sep 14, 2020
@juliushaertl juliushaertl deleted the backport/stable19/1032 branch September 14, 2020 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants