Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 madness #1035

Merged
merged 8 commits into from
Sep 29, 2020
Merged

IE11 madness #1035

merged 8 commits into from
Sep 29, 2020

Conversation

juliushaertl
Copy link
Member

  • Backport of Yet another IE11 fixing round #1032
  • Additionally downgrade core-js since for some reason this version causes issues with String.split with the regex that is used by prosemirror-model where "block+".split(/\s*(?=\b|\W|$)/) would return ["b", "l", "o", "c", "k", "+"] instead of ["block+"]
    However the exact same version combinations work fine on master, so I assume there are some wild polyfills overriding each other

Related issue for core-js zloirock/core-js#810

Otherwise we need to keep up with each dependency if it is actually IE11 compatible

Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Sep 11, 2020
@juliushaertl juliushaertl added this to the Nextcloud 18.0.10 milestone Sep 11, 2020
@juliushaertl
Copy link
Member Author

Tests needs adjustments as well:

Error: Cannot find module '@babel/polyfill'
Require stack:
- /home/runner/work/text/text/src/tests/setup.js

@danxuliu
Copy link
Member

I can not add anything valuable, so I will just leave this here (and I can not believe that @skjnldsv has not done it yet):

this-is-madness-madness-this-is-ie11

@rullzer rullzer mentioned this pull request Sep 28, 2020
1 task
@rullzer
Copy link
Member

rullzer commented Sep 29, 2020

sooo 18.0.10? or...?

Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>

Bump bundles

Signed-off-by: Julius Härtl <[email protected]>
@juliushaertl
Copy link
Member Author

Yes, please.

Rebased and updated bundles

@juliushaertl
Copy link
Member Author

Cypress failure currently expected

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@juliushaertl juliushaertl merged commit ee84f45 into stable18 Sep 29, 2020
@juliushaertl juliushaertl deleted the backport/stable18/1032 branch September 29, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants