refactor(link): use isMarkActive in insertOrSetLink

This way we do not hand in the active state
and avoid inconsistencies.

Signed-off-by: Max <[email protected]>

cypress/e2e/marks/Link.spec.js

@@ -50,7 +50,7 @@ describe('Link marks', { retries: 0 }, () => {
 
 		it('will insert a link in a normal paragraph', () => {
 			prepareEditor('hello\n', 3)
-			editor.commands.insertOrSetLink(false, 'https://nextcloud.com', { href: 'https://nextcloud.com' })
+			editor.commands.insertOrSetLink('https://nextcloud.com', { href: 'https://nextcloud.com' })
 			expectMarkdown(editor, 'he\n\n<https://nextcloud.com>\n\nllo')
 		})
 

src/components/Menu/ActionInsertLink.vue

@@ -200,7 +200,7 @@ export default {
 			// Avoid issues when parsing urls later on in markdown that might be entered in an invalid format (e.g. "mailto: [email protected]")
 			const href = url.replaceAll(' ', '%20')
 			const chain = this.$editor.chain()
-			chain.insertOrSetLink(this.state.active, text, { href })
+			chain.insertOrSetLink(text, { href })
 			chain.focus().run()
 		},
 		/**

src/marks/Link.js

@@ -23,6 +23,7 @@
 import TipTapLink from '@tiptap/extension-link'
 import { domHref, parseHref } from './../helpers/links.js'
 import { linkClicking } from '../plugins/links.js'
+import { isMarkActive } from '@tiptap/core'
 
 const Link = TipTapLink.extend({
 
@@ -73,11 +74,11 @@ const Link = TipTapLink.extend({
 			 * Insert a link if there currently is none.
 			 *
 			 */
-			insertOrSetLink: (active, text, attrs) => ({ state, chain, commands }) => {
+			insertOrSetLink: (text, attrs) => ({ state, chain, commands }) => {
 				// Check if any text is selected,
 				// if not insert the link using the given text property
 				if (state.selection.empty) {
-					if (active) {
+					if (isMarkActive(state, this.name)) {
 						commands.deleteNode('paragraph')
 					}
 					return chain().insertContent({