Skip to content

Hide online-only settings in Settings screen when offline #5458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Hide online-only settings in Settings screen when offline #5458

wants to merge 2 commits into from

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Oct 13, 2025 •
edited
Loading

Resolve #5440

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Bugfix/5440/hide settings Hide online-only settings in Settings screen when offline Oct 13, 2025
@sowjanyakch sowjanyakch self-assigned this Oct 13, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Oct 13, 2025
@sowjanyakch sowjanyakch force-pushed the bugfix/5440/hideSettings branch from b5f6adf to 78789a8 Compare October 15, 2025 13:34
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5458.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code6262
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9090

@sowjanyakch sowjanyakch enabled auto-merge October 15, 2025 13:58
rapterjet2004
rapterjet2004 requested changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@rapterjet2004 rapterjet2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide the proxy settings too, no use having them if the app is offline

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rapterjet2004 rapterjet2004 rapterjet2004 requested changes

@mahibi mahibi Awaiting requested review from mahibi

Requested changes must be addressed to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hide online-only settings in Settings screen when offline

2 participants

@sowjanyakch @rapterjet2004