Skip to content

reduce avatar size for group and all mentions #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 16, 2025

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Jul 8, 2025

fix #5138

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
old icons resized icons

Also fix avatar background color of mention chips for group and all mentions

🏚️ Before 🏑 After
old mention chips improvised background chip

Note: Replaced icons in the above screenshots with the outlined icons.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch changed the title Bugfix/5138/reduce avatar size reduce avatar size for group and all mentions Jul 9, 2025
@sowjanyakch sowjanyakch force-pushed the bugfix/5138/reduceAvatarSize branch from 19cc246 to 5377113 Compare July 9, 2025 08:24
@sowjanyakch sowjanyakch self-assigned this Jul 9, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Jul 9, 2025
@sowjanyakch sowjanyakch force-pushed the bugfix/5138/reduceAvatarSize branch 3 times, most recently from 8dfd2dd to 74c24c8 Compare July 16, 2025 08:27
@mahibi
Copy link
Collaborator

mahibi commented Jul 16, 2025

@rapterjet2004 can you review?

Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch sowjanyakch force-pushed the bugfix/5138/reduceAvatarSize branch from 74c24c8 to d25d5dc Compare July 16, 2025 15:36
@sowjanyakch sowjanyakch enabled auto-merge July 16, 2025 15:39
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9796
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code6161
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total9494

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5139-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit 186be51 into master Jul 16, 2025
15 of 16 checks passed
@sowjanyakch sowjanyakch deleted the bugfix/5138/reduceAvatarSize branch July 16, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reduce avatar size for group and all mentions in autocomplete view
3 participants