feat(signaling): Don't send all room userids in signaling server requests#16759
Open
feat(signaling): Don't send all room userids in signaling server requests#16759
Conversation
fancycode
force-pushed
the
remove-alluserids
branch
from
fc1fa68 to
edc7387
Compare
…ests Signed-off-by: Joachim Bauch <bauch@struktur.de>
fancycode
force-pushed
the
remove-alluserids
branch
from
df831a0 to
0b5509d
Compare
| 'delete' => [ | ||
| 'userids' => $userIds, | ||
| ], | ||
| 'delete' => (object)[], |
Member
There was a problem hiding this comment.
PHP way is usually:
Suggested change
| 'delete' => (object)[], | |
| 'delete' => new \stdClass(), |
nickvergessen
added
3. to review
feature: api 🛠️
nickvergessen
requested review from
danxuliu and
nickvergessen
and removed request for
nickvergessen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
alluseridsand similar lists from the signaling messages #13815🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required