fix(NewMessage): allow chat functionality with failed HPB connection

src/App.vue

@@ -387,6 +387,7 @@ export default {
 
 			if (from.name === 'conversation' && from.params.token !== to.params.token) {
 				this.$store.dispatch('leaveConversation', { token: from.params.token })
+				this.tokenStore.setLastJoinConversationFailed(false)
 			}
 
 			/**

src/components/NewMessage/NewMessage.vue

@@ -142,6 +142,7 @@
 			<NcActions
 				v-if="showSendActions"
 				force-menu
+				:disabled="disabled"
 				:primary="silentChat"
 				@close="submenu = null">
 				<template #icon>
@@ -512,7 +513,8 @@ export default {
 		},
 
 		disabled() {
-			return this.isReadOnly || this.noChatPermission || !this.currentConversationIsJoined || this.isRecordingAudio
+			return this.isReadOnly || this.noChatPermission || this.isRecordingAudio
+				|| (!this.currentConversationIsJoined && !this.currentConversationIsJoinedWithoutHPB)
 		},
 
 		scheduleMessageTime() {
@@ -539,7 +541,7 @@ export default {
 				return t('spreed', 'This conversation has been locked')
 			} else if (this.noChatPermission) {
 				return t('spreed', 'No permission to post messages in this conversation')
-			} else if (!this.currentConversationIsJoined) {
+			} else if (!this.currentConversationIsJoined && !this.currentConversationIsJoinedWithoutHPB) {
 				return t('spreed', 'Joining conversation …')
 			} else if (this.silentChat) {
 				return t('spreed', 'Write a message without notification')
@@ -594,6 +596,10 @@ export default {
 			return this.tokenStore.currentConversationIsJoined
 		},
 
+		currentConversationIsJoinedWithoutHPB() {
+			return this.tokenStore.currentConversationIsJoinedWithoutHPB
+		},
+
 		currentUploadId() {
 			return this.$store.getters.currentUploadId
 		},
@@ -721,6 +727,10 @@ export default {
 			this.focusInput()
 		},
 
+		currentConversationIsJoinedWithoutHPB() {
+			this.focusInput()
+		},
+
 		currentUploadId(value) {
 			if (value && !this.upload) {
 				this.text = ''

src/components/NewMessage/NewMessageAudioRecorder.vue

@@ -11,7 +11,7 @@
 			:aria-label="startRecordingTitle"
 			:aria-description="isMediaRecorderLoading ? t('spreed', 'Loading …') : undefined"
 			variant="tertiary"
-			:disabled="isMediaRecorderLoading"
+			:disabled="disabled || isMediaRecorderLoading"
 			@click="start">
 			<template #icon>
 				<IconMicrophoneOutline :size="20" />

src/init.js

@@ -58,6 +58,9 @@ window.OCA.Talk.registerParticipantSearchAction = ({ label, callback, show, icon
 EventBus.on('signaling-join-room', ([token]) => {
 	tokenStore.updateLastJoinedConversationToken(token)
 })
+EventBus.on('signaling-join-room-failed', ([token]) => {
+	tokenStore.setLastJoinConversationFailed(true)
+})
 
 EventBus.on('signaling-recording-status-changed', ([token, status]) => {
 	store.dispatch('setConversationProperties', { token, properties: { callRecording: status } })

src/services/EventBus.ts

@@ -45,6 +45,7 @@ export type Events = {
 	'signaling-join-call': [string, number]
 	'signaling-join-call-failed': [string, { meta: components['schemas']['OCSMeta'], data: { error: string } }]
 	'signaling-join-room': [string]
+	'signaling-join-room-failed': [string]
 	'signaling-participant-list-changed': void
 	'signaling-participant-list-updated': void
 	'signaling-recording-status-changed': [string, number]

src/stores/token.ts

@@ -17,8 +17,15 @@ export const useTokenStore = defineStore('token', () => {
 	 * A in the signaling server.
 	 */
 	const lastJoinedConversationToken = ref<'' | (string & {})>('')
+	/**
+	 * The joining of a room with the signaling server might fail
+	 * for various reasons. We still want to allow basic functionality
+	 * (e.g. chatting and file sharing) which does not depend on it.
+	 */
+	const lastJoinConversationFailed = ref<boolean>(false)
 
 	const currentConversationIsJoined = computed(() => token.value !== '' && lastJoinedConversationToken.value === token.value)
+	const currentConversationIsJoinedWithoutHPB = computed(() => token.value !== '' && lastJoinConversationFailed.value)
 
 	/**
 	 * @param newToken token of active conversation
@@ -43,16 +50,28 @@ export const useTokenStore = defineStore('token', () => {
 	 */
 	function updateLastJoinedConversationToken(newToken: string) {
 		lastJoinedConversationToken.value = newToken
+		// Reset last failed conversation attempt on successful join
+		lastJoinConversationFailed.value = false
+	}
+
+	/**
+	 * @param newValue value of the flag for last joined conversation
+	 */
+	function setLastJoinConversationFailed(newValue: boolean) {
+		lastJoinConversationFailed.value = newValue
 	}
 
 	return {
 		token,
 		fileIdForToken,
 		lastJoinedConversationToken,
+		lastJoinConversationFailed,
 		currentConversationIsJoined,
+		currentConversationIsJoinedWithoutHPB,
 
 		updateToken,
 		updateTokenAndFileIdForToken,
 		updateLastJoinedConversationToken,
+		setLastJoinConversationFailed,
 	}
 })

src/utils/signaling.js

@@ -637,6 +637,7 @@ function Standalone(settings, urls) {
 	this.maxReconnectIntervalMs = 16000
 	this.reconnectIntervalMs = this.initialReconnectIntervalMs
 	this.helloResponseErrorCount = 0
+	this.socketErrorCount = 0
 	this.ownSessionJoined = false
 	this.joinedUsers = {}
 	this.rooms = []
@@ -705,6 +706,7 @@ Signaling.Standalone.prototype.connect = function() {
 	window.signalingSocket = this.socket
 	this.socket.onopen = function(event) {
 		console.debug('Connected', event)
+		this.socketErrorCount = 0
 		if (this.signalingConnectionTimeout !== null) {
 			clearTimeout(this.signalingConnectionTimeout)
 			this.signalingConnectionTimeout = null
@@ -713,6 +715,10 @@ Signaling.Standalone.prototype.connect = function() {
 			this.signalingConnectionWarning.hideToast()
 			this.signalingConnectionWarning = null
 		}
+		if (this.signalingConnectionError !== null) {
+			this.signalingConnectionError.hideToast()
+			this.signalingConnectionError = null
+		}
 		this.reconnectIntervalMs = this.initialReconnectIntervalMs
 		if (this.settings.helloAuthParams['2.0']) {
 			this.waitForWelcomeTimeout = setTimeout(this.welcomeTimeout.bind(this), this.welcomeTimeoutMs)
@@ -730,10 +736,23 @@ Signaling.Standalone.prototype.connect = function() {
 			this.signalingConnectionWarning.hideToast()
 			this.signalingConnectionWarning = null
 		}
-		if (this.signalingConnectionError === null) {
+
+		this.socketErrorCount++
+		if (this.signalingConnectionError === null && this.socketErrorCount < 5) {
 			this.signalingConnectionError = showError(t('spreed', 'Failed to connect. Retrying …'), {
 				timeout: TOAST_PERMANENT_TIMEOUT,
 			})
+		} else if (this.socketErrorCount === 5) {
+			// Switch to a different message as several errors in a row in hello
+			// responses indicate that the signaling server might be unable to
+			// connect to Nextcloud.
+			if (this.signalingConnectionError) {
+				this.signalingConnectionError.hideToast()
+			}
+			this.signalingConnectionError = showError(t('spreed', 'Failed to connect. The signaling server may be set up incorrectly'), {
+				timeout: TOAST_PERMANENT_TIMEOUT,
+			})
+			this._trigger('joinRoomFailed', [this.settings.token])
 		}
 		this.reconnect()
 	}.bind(this)
@@ -1082,6 +1101,7 @@ Signaling.Standalone.prototype.helloResponseReceived = function(data) {
 			this.signalingConnectionError = showError(t('spreed', 'Failed to connect. The signaling server may be set up incorrectly'), {
 				timeout: TOAST_PERMANENT_TIMEOUT,
 			})
+			this._trigger('joinRoomFailed', [this.settings.token])
 		}
 
 		// TODO(fancycode): How should this be handled better?

src/utils/webrtc/index.js

@@ -7,6 +7,7 @@ import { isCancel } from '@nextcloud/axios'
 import { PARTICIPANT, PRIVACY, VIRTUAL_BACKGROUND } from '../../constants.ts'
 import BrowserStorage from '../../services/BrowserStorage.js'
 import { getTalkConfig } from '../../services/CapabilitiesManager.ts'
+import { EventBus } from '../../services/EventBus.ts'
 import { fetchSignalingSettings } from '../../services/signalingService.js'
 import store from '../../store/index.js'
 import { isSafari } from '../browserCheck.ts'
@@ -220,7 +221,14 @@ function setupWebRtc() {
 async function signalingJoinConversation(token, sessionId) {
 	await connectSignaling(token)
 	if (tokensInSignaling[token]) {
-		await signaling.joinRoom(token, sessionId)
+		try {
+			await signaling.joinRoom(token, sessionId)
+		} catch (error) {
+			// Initial 'signaling.joinRoom' might be in reconnection state
+			// so it returns a previous token after switch
+			EventBus.emit('signaling-join-room-failed', [])
+			throw error
+		}
 	}
 }