Skip to content

fix(session): Mark session as inactive when blurring the window #16351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(session): Mark session as inactive when blurring the window #16351

wants to merge 1 commit into from
+23 −10

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 18, 2025 •
edited
Loading

☑️ Resolves

  • Fix #…

Workaround in case of complaint:

localStorage.setItem('nextcloud_per_dGFsaw==_pause-notification-on-blur', 'yes')

  • Should make sure the readmarker is not set during an inactive session and when returning unless the user:

    • Writes message
    • Uses "Scroll to end" button
    • Reacts
    • Opens … menu on a message
    • Scrolls?

  • It should definitely not mark read when:

    • First user interaction is clicking on another chat
    • First user interaction is clicking on another app
    • First user interaction is navigating away
    • First user interaction is opening notifications or any other top bar menu

@nickvergessen nickvergessen added this to the 🍏 Next Major (33) milestone Nov 18, 2025
@nickvergessen nickvergessen self-assigned this Nov 18, 2025
@nickvergessen nickvergessen force-pushed the bugfix/noid/notification-attempt branch from a68d05c to 6f5f432 Compare November 19, 2025 15:52
Antreesy
Antreesy approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested

@nickvergessen nickvergessen marked this pull request as draft November 20, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels

2. developing bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client papercut

Projects

None yet

Milestone

🍏 Next Major (33)

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @Antreesy