Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MediaSettings): adjust transition direction based on language sup… #13539

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(MediaSettings): adjust transition direction based on language sup… #13539

merged 1 commit into from
Oct 14, 2024

Conversation

DorraJaouad
Copy link
Contributor

…port

☑️ Resolves

  • Fix this
Recording.2024-10-14.133022.mp4

🏡 After

Recording.2024-10-14.132842.mp4

🏁 Checklist

  • [] 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad added this to the 🌠 Next Minor milestone Oct 14, 2024
@DorraJaouad DorraJaouad self-assigned this Oct 14, 2024
Antreesy
Antreesy approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@DorraJaouad DorraJaouad merged commit 0e250cd into main Oct 14, 2024
46 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/transition-rtl branch October 14, 2024 12:40
@DorraJaouad
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @nickvergessen @Antreesy