Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle background blur in Talk if server doesn't support it #13507

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: handle background blur in Talk if server doesn't support it #13507

merged 2 commits into from
Oct 21, 2024
+158 −18

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 10, 2024 •
edited
Loading

☑️ Resolves

  • partially reverts ed39a6b
  • returns compatibility for Talk Desktop with versions below 29.0.4

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 10, 2024
@Antreesy Antreesy self-assigned this Oct 10, 2024
@Antreesy
Copy link
Contributor Author

Talk Desktop is locked on v25.0.2, so it will use fallback: https://github.com/nextcloud/talk-desktop/blob/a3ce89690df2a88b2d90b4cd54186b2c06c31673/src/shared/setupWebPage.js#L172

@Antreesy Antreesy requested a review from ShGKme October 10, 2024 10:07
@Antreesy Antreesy mentioned this pull request Oct 10, 2024
Merged
@Antreesy
Copy link
Contributor Author

/backport to stable30

DorraJaouad
DorraJaouad reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested yet 🚧

src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/SettingsDialog/SettingsDialog.vue Outdated Show resolved Hide resolved
src/components/SettingsDialog/SettingsDialog.vue Outdated Show resolved Hide resolved
src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/CallView/CallView.vue Show resolved Hide resolved
src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/12633/check-server-version-for-blur branch from d979129 to 21c4620 Compare October 11, 2024 08:25
@Antreesy
Copy link
Contributor Author

Antreesy commented Oct 11, 2024 •
edited
Loading

rebased onto webpack-vue-config 6.2.0, all changes since last review are in 2nd commit (for backport to 29)

ShGKme
ShGKme reviewed Oct 11, 2024
View reviewed changes
src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
src/components/CallView/CallView.vue Outdated Show resolved Hide resolved
@Antreesy Antreesy force-pushed the fix/12633/check-server-version-for-blur branch from 9c18389 to 830ac51 Compare October 18, 2024 09:03
@Antreesy
fix: handle background blur in Talk if server doesn't support it
ba03f82 
- partially reverts ed39a6b

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
fix: move version comparison to utils
503f639 
- post-review refactoring

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/12633/check-server-version-for-blur branch from 830ac51 to 503f639 Compare October 18, 2024 15:33
DorraJaouad
DorraJaouad approved these changes Oct 19, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ✅ and good code-wise

@Antreesy Antreesy merged commit da8a7a9 into main Oct 21, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12633/check-server-version-for-blur branch October 21, 2024 07:55
@backportbot backportbot bot mentioned this pull request Oct 21, 2024
Merged
2 tasks
@Antreesy
Copy link
Contributor Author

/backport to stable30.0

@backportbot backportbot bot mentioned this pull request Oct 21, 2024
Merged
2 tasks
@Antreesy
Copy link
Contributor Author

/backport 503f639 to stable29

@backportbot backportbot bot mentioned this pull request Oct 21, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client regression
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
4 participants
@Antreesy @nickvergessen @ShGKme @DorraJaouad