feat: show conversation settings, if URL hash is specified #13503
Conversation
Signed-off-by: Maksim Sukharev <[email protected]>
| } else if (this.$route.hash === '#settings') { | ||
| emit('show-conversation-settings', { token: this.token }) |
There was a problem hiding this comment.
This feature is a conversation-only feature, but handled here on a whole app level:
- It handles hash and emits conversation-related event on all the pages without conversation (token)
- Though it works right now, there is no guarantee conversation components are mounted and ready at this moment. It will be broken if we add anything async to the conversation page init.
- It uses
settingsfragment, leaving no tinny name for Talk settings if we add it later
There was a problem hiding this comment.
What about moving it to the conversation view?
There was a problem hiding this comment.
And about removing the hash from URL when the settings dialog is open
There was a problem hiding this comment.
- ConversationSettingsDialog is detached and independent from conversations. So it could be called on empty view as well, contrary to
#direct-call - It requires only token+conversation object to work. Maybe some additional request is needed here to ensure we fetched a conversation prior to opening the dialog
- Removing of hash should be fine, as long as it doesn't triggering any vue-router side effects
There was a problem hiding this comment.
- as long as it doesn't triggering any vue-router side effects
If it does, it is a bug that should be fixed
There was a problem hiding this comment.
It requires only token+conversation object to work
We don't have token+conversation outside the conversation view.
And a fragment cannot specify it. If we want to add ability to open setting for any conversation, it must be a query param. (Or if we want it to be combined with other fragments, like message id).
☑️ Resolves
#settingslink to directly open conversation settings #13485#direct-call🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist