Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(call): add option to enable blur background by default for all c… #13490

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DorraJaouad
Copy link
Contributor

…onversations

☑️ Resolves

  • Fix #…

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@DorraJaouad DorraJaouad self-assigned this Oct 7, 2024
@DorraJaouad DorraJaouad marked this pull request as draft October 7, 2024 17:39
@nickvergessen
Copy link
Member

I don't recall what we store in the local storage so far. its a "type" (string?) and in case type is image we also store the "name of the image" (string?) or what do we store?

@DorraJaouad
Copy link
Contributor Author

We store 3 info: enabled, type, and (url) if it is an image
image

@nickvergessen
Copy link
Member

We store all 3 in the backend in the future?

@DorraJaouad
Copy link
Contributor Author

We store all 3 in the backend in the future?

That's a better behavior IMO (not reliant on browser). Will it stay per conversation level or we change to one setting for all conversations?

@nickvergessen
Copy link
Member

The API stored config has to be 1 for all, otherwise we save too many preferences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants