fix(callView): move store to Pinia 🍍 #13432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
force-pushed
the
fix/noid/call-view-store
branch
from
65f388e
to
858c7a7
Compare
DorraJaouad
reviewed
Oct 11, 2024
Antreesy
force-pushed
the
fix/noid/call-view-store
branch
2 times, most recently
from
65fe004
to
bee36bd
Compare
Signed-off-by: Maksim Sukharev <[email protected]>
- forceCallView - isViewerOverlay - isGrid - isStripeOpen - isEmptyCallView - lastIsGrid - lastIsStripeOpen - presentationStarted - selectedVideoPeerId - callHasJustEnded Signed-off-by: Maksim Sukharev <[email protected]>
- remove isQualityWarningTooltipDismissed from store (reset on each call, so make sense to store in component only) - move participantRaisedHands to participantsStore - remove backgroundImageAverageColorCache from store (was dropped in 9094628) Signed-off-by: Maksim Sukharev <[email protected]>
- handleJoinCall - setCallViewMode - startPresentation - stopPresentation Signed-off-by: Maksim Sukharev <[email protected]>
- increase coverage Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/noid/call-view-store
branch
from
bee36bd
to
5ae2352
Compare
|
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
No visual changes
🚧 Tasks
🏁 Checklist