Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Call): introduce intermediary phase before joining call #13329

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(Call): introduce intermediary phase before joining call #13329

wants to merge 5 commits into from
+172 −67

Commits on Oct 9, 2024

  1. fix(ParticipantsStore): remove unnecessary event listeners and timeou… 

    …t. It's only received when using internal server. Replace them with events from the base class so we make sure it's always received. Also, add a new event for failed joining

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4c439c5 View commit details
    Browse the repository at this point in the history

  2. Fix(ParticipantsStore): separate joining states from each others (isI… 

    …nCall, connecting, connection failed)

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2d9743f View commit details
    Browse the repository at this point in the history

  3. feat(Call): Stop switching to CallView without a successful join. Int… 

    …roduce a failed join message dialog.

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    50db611 View commit details
    Browse the repository at this point in the history

  4. fix(Call): stop all media related streams (simulating end call) 

    Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e707c4e View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. WIP: distinguish the 2 phases of joining the call: connect to the cal… 

    …l AND wait for participants list

Signed-off-by: DorraJaouad <[email protected]>
    @DorraJaouad
    DorraJaouad committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0d90b15 View commit details
    Browse the repository at this point in the history