feat: KV cache based on predis#61690
Open
susnux wants to merge 2 commits into
Open
Conversation
susnux
added
enhancement
feature: caching
susnux
commented
Jul 1, 2026
susnux
commented
Jul 1, 2026
susnux
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
leftybournes
and removed request for
a team
susnux
added
3. to review
provokateurin
requested changes
Jul 2, 2026
Comment on lines
+183
to
+184
| // A leading slash indicates a Unix domain socket | ||
| $protocol = ($host !== '' && $host[0] === '/') ? 'unix' : 'tcp'; |
Member
There was a problem hiding this comment.
The socket could be at a relative path, no?
Contributor
Author
There was a problem hiding this comment.
no, to what would it be relative?
The config files? The PHP file? The nextcloud root?
Assisted-by: ClaudeCode:claude-opus-4-8 Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a new memcache implementation based on predis which does not require any PHP modules to be installed but instead relies on the pure PHP library predis.
This adds support for recent releases of Redis and Valkey (e.g. v8 or v9).
Some features are still missing (numbered databases in clusters) but this will be added soon by predis.
AI was used for documentation texts of config example and test generation.
Checklist
3. to review, feature component)stable32)AI (if applicable)