Add OCM Notification Received Event#61201
Open
mickenordin wants to merge 2 commits into
Open
Conversation
mickenordin
requested review from
CarlSchwan,
leftybournes,
provokateurin and
salmart-dev
and removed request for
a team
mickenordin
force-pushed
the
kano-ocm-notification-event
branch
from
e90ae9d to
ea274d3
Compare
CarlSchwan
approved these changes
Jun 11, 2026
CarlSchwan
reviewed
Jun 11, 2026
| $notificationEvent = new OCMNotificationReceivedEvent($notificationObject); | ||
| $this->dispatcher->dispatchTyped($notificationEvent); | ||
| } catch (\Exception $e) { | ||
| $this->logger->warning('error while dispatching OCM notification received event', ['exception' => $e]); |
Member
There was a problem hiding this comment.
What would be the expected error? the code doesn't look very dangerous
Contributor
Author
There was a problem hiding this comment.
My thinking is that this runs at the very end of the function, where everything has been successful so far. If one of the listeners fail, that problem could bubble up and cause an issue for something that has already been successful for all intents and purposes. Am I wrong in that assumption? Should I remove the try/catch?
OCM is standardizing and expanding the use of notifications and having an event for acting on in apps will be very useful. Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
mickenordin
force-pushed
the
kano-ocm-notification-event
branch
from
ea274d3 to
bac20d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OCM is standardizing and expanding the use of notifications and having an event for acting on in apps will be very useful. The immediate use-case will be for an app the implements the proposed federated group sprecification in OCM that relies heavily on notifications.
Checklist
3. to review, feature component)stable32)I will make a separate pr to nextcloud-documentation when and if this pr is accepted.
AI
I made an AI double check my test case, and made modifications after, but I wrote the code my self.