Skip to content

[stable33] Fix rendering custom columns in file lists#60526

Merged
danxuliu merged 3 commits into
stable33from
backport/60134/stable33
May 19, 2026
Merged

[stable33] Fix rendering custom columns in file lists#60526
danxuliu merged 3 commits into
stable33from
backport/60134/stable33

Conversation

@backportbot
Copy link
Copy Markdown

@backportbot backportbot Bot commented May 19, 2026

Backport of #60134

danxuliu added 2 commits May 19, 2026 11:19
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
CustomElementRender is used to render both IFileActions and IColumns.
However, the API to render both of them is different, and currently
CustomElementRender passes the arguments expected by IFileAction.
Fortunately those arguments are a superset of those expected by IColumn,
so they can be adapted when a CustomElementRender is used to render an
IColumn.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu
Copy link
Copy Markdown
Member

/compile amend /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the backport/60134/stable33 branch from 7b51d0e to c550efa Compare May 19, 2026 11:44
@danxuliu danxuliu marked this pull request as ready for review May 19, 2026 12:38
@danxuliu danxuliu requested a review from a team as a code owner May 19, 2026 12:38
@danxuliu danxuliu requested review from nfebe and removed request for a team May 19, 2026 12:38
Copy link
Copy Markdown
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@danxuliu danxuliu enabled auto-merge May 19, 2026 12:39
@danxuliu danxuliu merged commit eec0f10 into stable33 May 19, 2026
139 of 142 checks passed
@danxuliu danxuliu deleted the backport/60134/stable33 branch May 19, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants