Skip to content

test(settings): reduce flakiness of authorized group integration assertions#60379

Open
joshtrichards wants to merge 1 commit into
masterfrom
jtr/test-settings-auth-group-dups
Open

test(settings): reduce flakiness of authorized group integration assertions#60379
joshtrichards wants to merge 1 commit into
masterfrom
jtr/test-settings-auth-group-dups

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards commented May 15, 2026

Summary

This updates the DuplicateAssignmentIntegrationTest to avoid relying on unstable autoincrement ID equality in the integration DB environment. The test now focuses on verifying that the expected record exists with the correct groupId and class, which is more robust for sharded/integration-backed database runs.

This test was failing for me, in the Sharding database test integration work flow, for no discernible PR/branch specific reason:

There was 1 failure:

1) OCA\Settings\Tests\Integration\DuplicateAssignmentIntegrationTest::testMapperFindsExistingRecord
Failed asserting that 7 matches expected 0.

/home/runner/actions-runner/_work/server/server/apps/settings/tests/Integration/DuplicateAssignmentIntegrationTest.php:155

May be worth backporting, for the benefit of backport test runs (hah), since this code goes back to at least v31.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added tests Related to tests 2. developing Work in progress labels May 15, 2026
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone May 15, 2026
@joshtrichards joshtrichards marked this pull request as ready for review May 15, 2026 00:10
@joshtrichards joshtrichards requested a review from a team as a code owner May 15, 2026 00:10
@joshtrichards joshtrichards requested review from ArtificialOwl, CarlSchwan, icewind1991 and salmart-dev and removed request for a team May 15, 2026 00:10
@joshtrichards joshtrichards changed the title test(settings): harden authorized group integration assertions test(settings): reduce flakiness of authorized group integration assertions May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress developer experience tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant