fix(psalm): Fix static analysis issues in apps/*/tests #57404
+855
−912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
added
3. to review
There are still 1200 more to fix before we can enable static analysis for the tests. Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/fix-psalm-tests1
branch
from
159a46c to
5184975
Compare
CarlSchwan
requested review from
a team,
ChristophWurst,
SebastianKrupinski,
blizzz,
hamza221,
kesselb,
miaulalala,
nickvergessen and
tcitworld
as code owners
CarlSchwan
requested review from
artonge,
leftybournes,
provokateurin and
sorbaugh
and removed request for
a team
Open
artonge
approved these changes
Jan 9, 2026
| * @return Backend|MockObject | ||
| */ | ||
| protected function getBackend(array $methods = []): Backend { | ||
| protected function getBackend(array $methods = []): Backend|MockObject { |
Contributor
There was a problem hiding this comment.
Suggested change
| protected function getBackend(array $methods = []): Backend|MockObject { | |
| protected function getBackend(array $methods = []): Backend|(MockObject&Backend) { |
But I don't think php support it yet
| /** | ||
| * Creates a new global storages controller. | ||
| * | ||
| * @param string $AppName application name |
Contributor
There was a problem hiding this comment.
$appName is not type in the constructor
ChristophWurst
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are still 1200 more to fix before we can enable static analysis for the tests, but at least this prepare the ground for doing that by fixing some repetitive issues.
TODO
Checklist
3. to review, feature component)stable32)