fix(files): unexpected checksum header in multipart uploads caused by S3 default integrity change in AWS SDK for PHP #56078
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the configuration settings 'request_checksum_calculation' and 'response_checksum_validation' of the S3Client from the AWS SDK for PHP configurable. Signed-off-by: Fiehe Christoph <[email protected]>
cfiehe
requested review from
a team,
Altahrim,
Antreesy,
ArtificialOwl,
ChristophWurst,
JuliaKirschenheuter,
SebastianKrupinski,
artonge,
blizzz,
come-nc,
danxuliu,
edward-ly,
hamza221,
icewind1991,
julien-nc,
juliusknorr,
kesselb,
marcelklehr,
miaulalala,
nfebe,
nickvergessen,
provokateurin,
skjnldsv,
sorbaugh,
st3iny,
susnux,
szaimen and
tcitworld
as code owners
cfiehe
changed the title
miaulalala
approved these changes
Oct 29, 2025
susnux
removed request for
Antreesy,
ChristophWurst,
JuliaKirschenheuter,
SebastianKrupinski,
blizzz,
danxuliu,
edward-ly,
hamza221,
julien-nc,
kesselb,
luka-nextcloud,
marcelklehr,
mejo-,
st3iny,
szaimen and
tcitworld
kesselb
added
the
pending documentation
kesselb
changed the base branch from
master
to
fix/56077/s3-configure-checksum-defaults
kesselb
merged commit 39c5999
into
nextcloud:fix/56077/s3-configure-checksum-defaults
1 of 2 checks passed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit makes the configuration settings
request_checksum_calculationandresponse_checksum_validationof the S3Client from the AWS SDK for PHP configurable via the objectstore S3 configuration section of theconfig.php. Allowed values arewhen_requiredandwhen_supported(new default since AWS SDK for PHP >= 3.337.0).Signed-off-by: Fiehe Christoph [email protected]