Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Sharing sidebar UI redesign #50282

Merged
merged 6 commits into from
Jan 23, 2025
Merged

refactor: Sharing sidebar UI redesign #50282

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fde013b
refactor(files_sharing): move deprecated projects component
thlehmann-ionos Nov 7, 2024
ae854e0
refactor(files_sharing): Split internal & external shares
nfebe Jan 21, 2025
33eaf9c
feat(files_sharing): Modularize `SharingInput` to adapt with share se…
nfebe Jan 21, 2025
14573fc
feat: Improve create link texts
nfebe Jan 22, 2025
5ee354f
feat: Only show show inherited shares section if present
nfebe Jan 22, 2025
7ec7a4f
chore(assets): Recompile assets
nextcloud-command Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(files_sharing): move deprecated projects component 
Primarily to move it out of the way for changes in the source location.

The feature was deprecated in version 25 (#28320), five versions ago.

Refs: #48925
Signed-off-by: nfebe <[email protected]>
  • Loading branch information
@thlehmann-ionos @nfebe
thlehmann-ionos authored and nfebe committed Jan 23, 2025
commit fde013b3c710487ce705c39de66148098a1e7507
15 changes: 9 additions & 6 deletions apps/files_sharing/src/views/SharingTab.vue
View file
Original file line number Diff line number Diff line change
@@ -54,12 +54,6 @@

<!-- internal link copy -->
<SharingEntryInternal :file-info="fileInfo" />

<!-- projects -->
<CollectionList v-if="projectsEnabled && fileInfo"
:id="`${fileInfo.id}`"
type="file"
:name="fileInfo.name" />
</div>

<!-- additional entries, use it with cautious -->
@@ -71,6 +65,15 @@
<component :is="section($refs['section-'+index], fileInfo)" :file-info="fileInfo" />
</div>

<!-- projects (deprecated as of NC25 (replaced by related_resources) - see instance config "projects.enabled" ; ignore this / remove it / move into own section) -->
<div v-show="!showSharingDetailsView && projectsEnabled && fileInfo"
class="sharingTab__additionalContent">
<CollectionList
:id="`${fileInfo.id}`"
type="file"
:name="fileInfo.name" />
</div>

<!-- share details -->
<SharingDetailsTab v-if="showSharingDetailsView"
:file-info="shareDetailsData.fileInfo"