Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix focus loop on tab navigation in Add to album modal + Migrate to new UploadPicker API #2256

Merged
merged 8 commits into from
Jan 30, 2024
Merged

fix: Fix focus loop on tab navigation in Add to album modal + Migrate to new UploadPicker API #2256

merged 8 commits into from
Jan 30, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 17, 2024 •
edited
Loading

Summary

  • Fix max call stack errors with deps upgrade
  • Fix tab navigation loop (not an ideal solution but also a minimally invasive solution for now at least)

@Pytal Pytal self-assigned this Jan 17, 2024
@Pytal Pytal changed the title chore: Bump @nextcloud deps fix: Focus trap glitch in add to album modal Jan 17, 2024
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal force-pushed the fix/a11y/focus-trap-add-to-album branch from 45fae76 to 2b11e70 Compare January 23, 2024 03:02
@Pytal

This comment was marked as resolved.

Sign in to view
@artonge

This comment was marked as resolved.

Sign in to view
@skjnldsv

This comment was marked as resolved.

Sign in to view
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal closed this Jan 24, 2024
@Pytal Pytal mentioned this pull request Jan 24, 2024
Closed
@Pytal Pytal deleted the fix/a11y/focus-trap-add-to-album branch January 24, 2024 00:11
@artonge artonge restored the fix/a11y/focus-trap-add-to-album branch January 25, 2024 11:14
@artonge artonge reopened this Jan 25, 2024
@artonge

This comment was marked as resolved.

Sign in to view
@artonge artonge force-pushed the fix/a11y/focus-trap-add-to-album branch from a9b779b to 46629ca Compare January 25, 2024 14:02
@Pytal

This comment was marked as resolved.

Sign in to view
@artonge artonge force-pushed the fix/a11y/focus-trap-add-to-album branch from 46629ca to 1ef4806 Compare January 29, 2024 14:37
@Pytal Pytal force-pushed the fix/a11y/focus-trap-add-to-album branch from 1ef4806 to 15ae2a9 Compare January 29, 2024 20:54
@Pytal Pytal changed the title fix: Focus trap glitch in add to album modal fix: Fix focus loop on tab in Add to album modal Jan 29, 2024
@Pytal Pytal marked this pull request as ready for review January 29, 2024 21:10
@Pytal Pytal changed the title fix: Fix focus loop on tab in Add to album modal fix: Fix focus loop on tab navigation in Add to album modal Jan 29, 2024
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal @artonge
chore: Bump @nextcloud deps
bb79f5a 
Signed-off-by: Christopher Ng <[email protected]>
@artonge artonge force-pushed the fix/a11y/focus-trap-add-to-album branch from 15ae2a9 to 14624d3 Compare January 30, 2024 10:19
@Pytal Pytal force-pushed the fix/a11y/focus-trap-add-to-album branch from 14624d3 to a5a0668 Compare January 30, 2024 17:38
@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jan 30, 2024
@Pytal Pytal enabled auto-merge January 30, 2024 17:39
@Pytal Pytal force-pushed the fix/a11y/focus-trap-add-to-album branch from af706d4 to 74152a6 Compare January 30, 2024 22:00
@Pytal
Copy link
Member Author

Pytal commented Jan 30, 2024

/compile amend /

@Pytal Pytal changed the title fix: Fix focus loop on tab navigation in Add to album modal fix: Fix focus loop on tab navigation in Add to album modal + Migrate to new UploadPicker API Jan 30, 2024
@Pytal
Copy link
Member Author

Pytal commented Jan 30, 2024

/backport to stable28

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 30, 2024
@nextcloud-command nextcloud-command force-pushed the fix/a11y/focus-trap-add-to-album branch from 74152a6 to 958318c Compare January 30, 2024 22:06
@Pytal Pytal force-pushed the fix/a11y/focus-trap-add-to-album branch from 958318c to 5029447 Compare January 30, 2024 22:50
@Pytal Pytal force-pushed the fix/a11y/focus-trap-add-to-album branch from 5029447 to 0a25bfc Compare January 30, 2024 22:54
@Pytal Pytal merged commit 901627f into master Jan 30, 2024
34 checks passed
@Pytal Pytal deleted the fix/a11y/focus-trap-add-to-album branch January 30, 2024 23:14
@backportbot backportbot bot mentioned this pull request Jan 30, 2024
Merged
2 tasks
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jan 30, 2024
@JuliaKirschenheuter
Copy link
Contributor

Great that it works! Thanks Chris!

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
@joshtrichards joshtrichards mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @artonge @skjnldsv @JuliaKirschenheuter @nextcloud-command